Skip to content

Conversation

@jwills
Copy link
Contributor

@jwills jwills commented Aug 8, 2025

Fixes #682

Centralizes chunk lock-file cleanup in Reader’s delete path and makes it compression-agnostic by removing any .lock files matching the chunk’s base filename prefix. Adds a test that simulates a non-local downloader which leaves lockfiles in place to ensure cleanup is effective.

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?
I think gpt5 enjoyed itself, and if gpt5 is happy, I'm happy

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84%. Comparing base (a543725) to head (5f8ea89).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #683   +/-   ##
===================================
  Coverage    84%    84%           
===================================
  Files        52     52           
  Lines      7021   7023    +2     
===================================
+ Hits       5900   5904    +4     
+ Misses     1121   1119    -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@deependujha deependujha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great contribution @jwills and thanks GPT5. 🚀

Copy link
Collaborator

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😊

@tchaton tchaton merged commit e572b84 into Lightning-AI:main Aug 10, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Streaming cache leaves stale compressed lock files (e.g., *.zstd.bin.lock ) after chunk deletion

5 participants