Skip to content

Conversation

@pwgardipee
Copy link
Collaborator

What does this PR do?

  1. Adds r2:// and lightning_storage in places where it was missing to resolve directories properly.
  2. Adds data_connection_id in missing places which is required for resolving lightning_storage directories
    Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 18, 2025

Codecov Report

❌ Patch coverage is 60.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84%. Comparing base (04bd7ae) to head (d73992e).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #715   +/-   ##
===================================
- Coverage    84%    84%   -0%     
===================================
  Files        52     52           
  Lines      7277   7285    +8     
===================================
+ Hits       6128   6132    +4     
- Misses     1149   1153    +4     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Peyton Gardipee added 2 commits September 18, 2025 20:45
@tchaton tchaton enabled auto-merge (squash) September 18, 2025 22:35
@tchaton tchaton disabled auto-merge September 18, 2025 22:51
@tchaton tchaton merged commit 151e012 into main Sep 18, 2025
47 of 49 checks passed
@tchaton tchaton deleted the pwgardipee/fix-r2-compression branch September 18, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants