Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
What does this PR do?
From Torchaudio >=2.9, Most APIs marked as pytorch/audio#3902 (comment) are now removed. This results in CI tests failing for
litdata-torchaudio
dataset optimization. check failing tests here.We can either bump
torchaudio
to older release as a quick fix, or for latest torchaudio support, we need to update existing api calls, and installffmpeg
followed bytorchcodec
to pass tests.As a quick fix, this PR pins torchaudio to an older compatible release to restore CI stability.
If we’d prefer to support the latest
Torchaudio
release instead, I can update this PR to include the necessary API adjustments and addffmpeg
,torchcodec
, andtorchaudio
installation steps in the CI workflow.PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃