Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Nov 2, 2021

What does this PR do?

Add display_every_n_epochs argument to RichProgressBar. Set to a non-negative integer to display progress bar every n epochs.

Screen Shot 2021-11-02 at 1 27 05 PM

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@kaushikb11 kaushikb11 force-pushed the support/display_every_n_epoch branch from bcdc5b5 to 4a1274d Compare November 2, 2021 07:20
@kaushikb11 kaushikb11 self-assigned this Nov 2, 2021
@kaushikb11 kaushikb11 added callback feature Is an improvement or enhancement labels Nov 2, 2021
@kaushikb11 kaushikb11 added this to the v1.5 milestone Nov 2, 2021
@kaushikb11 kaushikb11 marked this pull request as ready for review November 2, 2021 08:01
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton
Copy link
Contributor

tchaton commented Nov 2, 2021

Hey @kaushikb11.

By the same occasion, do you think you could look into the fickering on the progress bar. The last line isn't aligned properly due the loss.

Best,
T.C

@kaushikb11
Copy link
Contributor Author

do you think you could look into the fickering on the progress bar.

@tchaton The flickering issue seems to exist for VS code terminal. It works as expected on ITerm2. I think we would need to raise an issue on Rich repo. cc @SeanNaren

@kaushikb11 kaushikb11 added the priority: 0 High priority task label Nov 2, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mergify mergify bot added the ready PRs ready to be merged label Nov 2, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) November 2, 2021 12:27
@kaushikb11 kaushikb11 force-pushed the support/display_every_n_epoch branch from 8b0e3d8 to b454fe2 Compare November 2, 2021 12:28
@awaelchli awaelchli added the design Includes a design discussion label Nov 2, 2021
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unblock

@kaushikb11 kaushikb11 requested a review from awaelchli November 2, 2021 16:05
@rohitgr7 rohitgr7 changed the title Add display_every_n_epochs argument to RichProgressBar Add leave argument to RichProgressBar Nov 2, 2021
@rohitgr7 rohitgr7 disabled auto-merge November 2, 2021 16:12
@rohitgr7 rohitgr7 enabled auto-merge (squash) November 2, 2021 16:12
@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2021

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@lexierule lexierule disabled auto-merge November 2, 2021 17:20
@lexierule lexierule merged commit 34fcb87 into master Nov 2, 2021
@lexierule lexierule deleted the support/display_every_n_epoch branch November 2, 2021 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

callback design Includes a design discussion feature Is an improvement or enhancement priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants