Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 10, 2021

What does this PR do?

Contains all bugfixes to be released next week. As bugfixes get merged to master, they will get cherry-picked into this branch by the individual author (core) or on-caller.

For staff/core: The new release guide is here.

gh pr list -s merged -S 'merged:2021-11-09T18:30:00.000Z..2021-11-16T18:30:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == 
"1.5.x") or (.milestone.title == null)) | [.mergedAt, .url, .mergeCommit.oid, .title] | join(" ")' --limit 100

2021-11-16T04:36:48Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10550 6dfcb6afc542506c17875e23aa10cf7cbd6bcec2 Skip strategy=ddp_spawn, accelerator=cpu, python>=3.9 tests
2021-11-15T22:31:45Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10486 60850ef51002fe1525208149a5502e2d4637b6cb fix overfit_batch sampler replacement logic
2021-11-15T22:12:55Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10470 65ebfed3aedcbeb38dd1ada0b0a4b32f13038929 Fix `to_torchscript()` causing false positive deprecation warnings
2021-11-15T21:04:49Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10520 dcafc95f2b0fd3f176d425139ca99676ce943a12 Avoid deprecated `progress_bar_refresh_rate` usage
2021-11-15T19:13:01Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10493 1de3539eac6e83992735b64bf517beaa840a13f2 Resolve instantiation problem with init_meta_context
2021-11-15T10:03:46Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10463 ffb40060c099f08f1f5b3e94ea58284e6503e556 shutdown workers on failure
2021-11-12T18:03:47Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10461 847e24011af32dcf7bf14577b1e2e0a5fe3fb727 Squeeze the early stopping monitor
2021-11-11T19:53:40Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10454 09cf167237e867f1ec67a5db87e5a02c2cea4b69 Change attributes of `RichProgressBarTheme` dataclass
2021-11-10T04:42:27Z https://github.com/PyTorchLightning/pytorch-lightning/pull/9702 ce149f64517883caf8abce7718c7bca5769f43ce Fix support for dataclasses with ClassVar/InitVar in `apply_to_collection`
2021-11-09T21:25:54Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10439 eeef5a80ac4eac49dfca6d63c34a1c5627dbe496 Update Changelog for v1.5.1
2021-11-09T20:06:10Z https://github.com/PyTorchLightning/pytorch-lightning/pull/10374 8d810d614472b8c68caaac6cd413210569c5df63 Enable distributed training with CombinedDataLoader and max_size_cycle


Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

@awaelchli awaelchli added bug Something isn't working release labels Nov 10, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 10, 2021
@awaelchli
Copy link
Contributor Author

#10559 will be included if time allows

Raahul-Singh and others added 2 commits November 16, 2021 17:41
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 16, 2021
@lexierule lexierule merged commit 0865ad1 into release/1.5.x Nov 16, 2021
@lexierule lexierule deleted the 1.5.2-draft branch November 16, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready PRs ready to be merged release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants