Test deprecated API for 0.8.0 and 0.9.0 #1071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Borda! Thanks for updating this PR.
Comment last updated at 2020-03-06 15:36:15 UTC |
Borda
changed the title
Borda
commented
Mar 6, 2020
Borda
added a commit
that referenced
this pull request
Mar 6, 2020
* till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu>
williamFalcon
added a commit
that referenced
this pull request
Mar 6, 2020
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Test deprecated API for 0.8.0 and 0.9.0 (#1071) * till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu> * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Borda
added a commit
that referenced
this pull request
Mar 6, 2020
* till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu>
Borda
added a commit
that referenced
this pull request
Mar 6, 2020
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Test deprecated API for 0.8.0 and 0.9.0 (#1071) * till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu> * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu>
tullie
pushed a commit
to tullie/pytorch-lightning
that referenced
this pull request
Apr 3, 2020
* Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Update README.md * Test deprecated API for 0.8.0 and 0.9.0 (Lightning-AI#1071) * till 0.8 * refactor * fix tests * fix tests * deprx till 0.9 * Update trainer.py * Apply suggestions from code review Co-authored-by: William Falcon <waf2107@columbia.edu> * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test * updated test Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Verify that all deprecated API is correctly used... this one takes only 0.8.0
TrainerAPI and argumentsPR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃