-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Fix pickling of KFoldLoop #12441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pickling of KFoldLoop #12441
Conversation
for more information, see https://pre-commit.ci
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://pytorch-lightning.readthedocs.io/en/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Slack. Thank you for your contributions. |
|
This pull request is going to be closed. Please feel free to reopen it create a new from the actual master. |
Codecov Report
@@ Coverage Diff @@
## master #12441 +/- ##
=========================================
- Coverage 92% 89% -3%
=========================================
Files 207 218 +11
Lines 17702 22549 +4847
=========================================
+ Hits 16235 20081 +3846
- Misses 1467 2468 +1001 |
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
krshrimali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @niberger for the contribution! 🚀 LGTM!
akihironitta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* allow pickling of KFoldLoop * Update pl_examples/loop_examples/kfold.py Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Nicolas Berger <nicolas.berger@inait.ai> Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
* allow pickling of KFoldLoop * Update pl_examples/loop_examples/kfold.py Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Nicolas Berger <nicolas.berger@inait.ai> Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
* allow pickling of KFoldLoop * Update pl_examples/loop_examples/kfold.py Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Nicolas Berger <nicolas.berger@inait.ai> Co-authored-by: Kushashwa Ravi Shrimali <kushashwaravishrimali@gmail.com>
What does this PR do?
Make the
KFoldLoopexample class serializable via pickling.It allow the use of this example with the
ddp_spawnstrategy.Without this fix, the deserialization of
KFoldLoopcrash by entering an endless recursive call of__getattr__("fitloop").No test written as this only improve an example.
Fixes #12439
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃