Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Apr 11, 2022

… the user passes invalid ([]/0/'0') values to the devices flag

What does this PR do?

Without the updates in this PR and when the accelerator is available, the user gets the following error for

Trainer(accelerator="gpu", devices=0/"0"/[])
    self._parallel_devices = self.accelerator.get_parallel_devices(self._devices_flag)
  File "/home/jovyan/pytorch-lightning/pytorch_lightning/accelerators/gpu.py", line 82, in get_parallel_devices
    return [torch.device("cuda", i) for i in devices]
TypeError: 'NoneType' object is not iterable

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @akihironitta @justusschock

… the user passes invalid ([]/0/'0') values to the devices flag
@kaushikb11 kaushikb11 self-assigned this Apr 11, 2022
@kaushikb11 kaushikb11 added bug Something isn't working priority: 0 High priority task accelerator labels Apr 11, 2022
@kaushikb11 kaushikb11 changed the title Raise MisconfigurationException when the accelerator is available but… Raise MisconfigurationException when the accelerator is available but… Apr 11, 2022
@mergify mergify bot added the ready PRs ready to be merged label Apr 11, 2022
@carmocca carmocca added this to the 1.6.x milestone Apr 11, 2022
Copy link
Member

@justusschock justusschock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one very nit question :)

@kaushikb11 kaushikb11 merged commit 91c3d8e into master Apr 11, 2022
@kaushikb11 kaushikb11 deleted the acc/devices_empty branch April 11, 2022 18:01
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator bug Something isn't working priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants