Skip to content

Conversation

@rohitgr7
Copy link
Contributor

@rohitgr7 rohitgr7 commented Apr 12, 2022

What does this PR do?

Unblocks master. Tests are failing on master.

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda @SeanNaren @awaelchli @rohitgr7

Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🤖

@rohitgr7 rohitgr7 enabled auto-merge (squash) April 12, 2022 08:53
@mergify mergify bot added the ready PRs ready to be merged label Apr 12, 2022
@rohitgr7 rohitgr7 merged commit 6fcb590 into master Apr 12, 2022
@rohitgr7 rohitgr7 deleted the ci/deepspeed branch April 12, 2022 09:27
rohitgr7 added a commit that referenced this pull request Apr 12, 2022
lexierule pushed a commit that referenced this pull request Apr 13, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged strategy: deepspeed tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants