Improve LigtningEnum, etc. #12750
Merged
Improve LigtningEnum, etc. #12750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change `from_str` to use `__members__` for enum names change `from_str` to use built-in `__getitem__` syntax for names make `_OnAccessEnumMeta` more robust and efficient create `DeprecatedEnum` as a base class change `DistributedType` and `DeviceType` to use `DeprecatedEnum`
ethanfurman
requested review from
Borda,
SeanNaren,
carmocca and
tchaton
as code owners
for more information, see https://pre-commit.ci
Borda
approved these changes
Apr 13, 2022
ethanwharris
approved these changes
Apr 13, 2022
rohitgr7
approved these changes
Apr 13, 2022
Make private by prepending an `_`.
add missing `_`
awaelchli
approved these changes
Apr 16, 2022
Contributor
awaelchli
left a comment
awaelchli
left a comment
There was a problem hiding this comment.
Someone is playing with metaclasses! <3
carmocca
approved these changes
Apr 18, 2022
carmocca
approved these changes
Apr 22, 2022
otaj
pushed a commit
that referenced
this pull request
Apr 25, 2022
lexierule
pushed a commit
that referenced
this pull request
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12749
from_strto use__members__for enum namesfrom_strto use built-in__getitem__syntax for names_OnAccessEnumMetamore robust and efficientDeprecatedEnumas a base classDistributedTypeandDeviceTypeto useDeprecatedEnum