Skip to content

Fix materialize_module recursively setting its child module #12870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
May 13, 2022
Merged

Fix materialize_module recursively setting its child module #12870

merged 15 commits into from
May 13, 2022

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Apr 24, 2022 •
edited by github-actions bot
Loading

What does this PR do?

Part of #12373.
Fixes #13042 which is part of #12984.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @otaj @Borda

@akihironitta akihironitta mentioned this pull request Apr 25, 2022
Merged
12 tasks
Borda
Borda reviewed Apr 27, 2022
View reviewed changes
@akihironitta akihironitta mentioned this pull request May 2, 2022
Closed
5 tasks
@akihironitta akihironitta reopened this May 9, 2022
@akihironitta akihironitta added the bug Something isn't working label May 12, 2022
@akihironitta akihironitta added this to the 1.6.x milestone May 12, 2022
akihironitta
akihironitta commented May 12, 2022
View reviewed changes
@akihironitta akihironitta changed the title [wip] Bugfix/init meta fit Fix materialize_module recursively setting its child module May 12, 2022
@mergify mergify bot removed the has conflicts label May 12, 2022
@akihironitta akihironitta mentioned this pull request May 12, 2022
Merged
12 tasks
@mergify mergify bot added the ready PRs ready to be merged label May 12, 2022
@Borda Borda enabled auto-merge (squash) May 12, 2022 13:18
awaelchli
awaelchli reviewed May 12, 2022
View reviewed changes
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels May 13, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts ready PRs ready to be merged labels May 13, 2022
@Borda Borda merged commit 03039a2 into master May 13, 2022
@Borda Borda deleted the bugfix/init-meta-fit branch May 13, 2022 18:05
carmocca pushed a commit that referenced this pull request May 13, 2022
@akihironitta @carmocca
Fix materialize_module recursively setting its child module (#12870)
27db899
ashleve pushed a commit to ashleve/pytorch-lightning that referenced this pull request May 13, 2022
@akihironitta @pre-commit-ci @ashleve
Fix materialize_module recursively setting its child module (Lightn…
f2538b1 
…ing-AI#12870)

* Don't set materialized child to child's child
* Update CHANGELOG

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ashleve added a commit to ashleve/pytorch-lightning that referenced this pull request May 14, 2022
@ashleve
Revert "Fix materialize_module recursively setting its child module (…
9c2a40c 
…Lightning-AI#12870)"

This reverts commit f2538b1.
carmocca pushed a commit that referenced this pull request May 31, 2022
@akihironitta @carmocca
Fix materialize_module recursively setting its child module (#12870)
6009936
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@akihironitta @lexierule
Fix materialize_module recursively setting its child module (#12870)
941c2d6
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

+4 more reviewers

@awaelchli awaelchli awaelchli left review comments

@otaj otaj otaj approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working ready PRs ready to be merged

Projects

None yet

Milestone

pl:1.6.x

Development

Successfully merging this pull request may close these issues.

nn.Module subclasses uncollected by get_all_subclasses raise RecursionError after materialization

6 participants

@akihironitta @awaelchli @Borda @otaj @SeanNaren @carmocca