Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Apr 28, 2022

What does this PR do?

See title.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • [n/a] Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@akihironitta akihironitta changed the title [wip] Fix cmake installation in nightly docker builds Fix cmake installation in nightly docker builds Apr 28, 2022
@akihironitta akihironitta added bug Something isn't working ci Continuous Integration labels Apr 28, 2022
@akihironitta akihironitta added this to the 1.6.x milestone Apr 28, 2022
@Borda Borda enabled auto-merge (squash) April 28, 2022 04:06
@mergify mergify bot added the ready PRs ready to be merged label Apr 28, 2022
@mergify mergify bot requested a review from a team April 28, 2022 04:07
@Borda Borda merged commit 98b206e into master Apr 28, 2022
@Borda Borda deleted the ci/fix-cmake-install branch April 28, 2022 07:44
carmocca pushed a commit that referenced this pull request Apr 28, 2022
lexierule pushed a commit that referenced this pull request May 3, 2022
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants