Add hook test for reloading with max epochs #12932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmocca
requested review from
Borda,
SeanNaren,
awaelchli,
justusschock,
kaushikb11,
rohitgr7,
tchaton and
williamFalcon
as code owners
rohitgr7
approved these changes
Apr 29, 2022
otaj
approved these changes
May 2, 2022
Borda
approved these changes
May 2, 2022
carmocca
added a commit
that referenced
this pull request
May 2, 2022
carmocca
added a commit
that referenced
this pull request
May 3, 2022
carmocca
added a commit
that referenced
this pull request
May 3, 2022
lexierule
pushed a commit
that referenced
this pull request
May 3, 2022
awaelchli
reviewed
May 8, 2022
|
|
||
| called = [] | ||
| callback = HookedCallback(called) | ||
| # already performed 1 step, resume and do 2 more |
Contributor
There was a problem hiding this comment.
Can you explain the comment? I think it's wrong.
We first train 2 steps (1 epoch).
Then, we resume to do 2 more steps (1 additional epoch)
Contributor
There was a problem hiding this comment.
yep... it's a small typo... must be copied from the test right below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add test to ease the review of #12821
Setting the 1.6.x milestone because #12821 will need to land there
Does your PR introduce any breaking changes? If yes, please list them.
None
cc @Borda @akihironitta @carmocca @awaelchli @ninginthecloud @daniellepintz @rohitgr7