Skip to content

parse strategies as own extras #12975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 9, 2022
Merged

parse strategies as own extras #12975

merged 4 commits into from
May 9, 2022

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented May 4, 2022 •
edited by github-actions bot
Loading

What does this PR do?

This brings clarity to installing needed strategies just enriched by the correct version

pip install pytorch-lightning[horovod]

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @justusschock @awaelchli @rohitgr7

@Borda Borda added the refactor label May 4, 2022
@Borda Borda enabled auto-merge (squash) May 4, 2022 16:59
carmocca
carmocca suggested changes May 4, 2022
View reviewed changes
@akihironitta akihironitta added this to the 1.6.x milestone May 5, 2022
@Borda Borda requested a review from carmocca May 5, 2022 16:54
carmocca
carmocca approved these changes May 5, 2022
View reviewed changes
@Borda Borda mentioned this pull request May 6, 2022
Closed
4 tasks
@Borda
Copy link
Collaborator Author

Borda commented May 6, 2022 •
edited
Loading

@carmocca in fact, let's keep _load_requirements as we may reuse it in freezing requirements... #12994

@mergify mergify bot added the ready PRs ready to be merged label May 9, 2022
Borda and others added 4 commits May 9, 2022 09:33
@Borda Borda force-pushed the req/parse-srategies branch from 9acdbba to b865d89 Compare May 9, 2022 07:33
Borda
Borda commented May 9, 2022
View reviewed changes
Copy link
Collaborator Author

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go

@lexierule lexierule disabled auto-merge May 9, 2022 13:25
@lexierule lexierule merged commit 783ec43 into master May 9, 2022
@lexierule lexierule deleted the req/parse-srategies branch May 9, 2022 13:25
carmocca added a commit that referenced this pull request May 9, 2022
@Borda @carmocca
parse strategies as own extras (#12975)
bc430a9 
* parse strategies as own extras

* prune devel

* Update Makefile

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* revert parse_requirements

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
carmocca added a commit that referenced this pull request May 31, 2022
@Borda @carmocca
parse strategies as own extras (#12975)
b3b8ec6 
* parse strategies as own extras

* prune devel

* Update Makefile

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* revert parse_requirements

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Jun 1, 2022
@Borda @carmocca @lexierule
parse strategies as own extras (#12975)
298ad22 
* parse strategies as own extras

* prune devel

* Update Makefile

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* revert parse_requirements

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@rohitgr7 rohitgr7 mentioned this pull request Jul 1, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@awaelchli awaelchli Awaiting requested review from awaelchli

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

4 more reviewers

@otaj otaj otaj approved these changes

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

@kaushikb11 kaushikb11 kaushikb11 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready PRs ready to be merged refactor

Projects

None yet

Milestone

pl:1.6.x

Development

Successfully merging this pull request may close these issues.

6 participants

@Borda @otaj @carmocca @akihironitta @kaushikb11 @lexierule