-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add CI app cloud e2e #13499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add CI app cloud e2e #13499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…ng into add-ci-examples-e2e
…ng into add-ci-examples-e2e
06b74f4 to
5969c1e
Compare
tchaton
reviewed
Jul 15, 2022
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's skip those tests with PL
for more information, see https://pre-commit.ci
…ng into add-ci-examples-e2e
Borda
reviewed
Jul 15, 2022
Borda
reviewed
Jul 15, 2022
Borda
reviewed
Jul 15, 2022
Borda
approved these changes
Jul 17, 2022
tchaton
approved these changes
Jul 17, 2022
Contributor
tchaton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
akihironitta
approved these changes
Jul 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adding the following cloud e2e tests to run apps on the cloud:
To make run the tests, we need to have at least the following secrets:
LIGHTNING_CLOUD_URL: lightning cloud URL e.g. https://lightning.aiLIGHTNING_USERNAME: lightning.ai usernameLIGHTNING_USER_ID: lightning.ai user IDLIGHTNING_API_KEY: lightning.ai API keyDoes your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃
cc @carmocca @akihironitta @Borda @tchaton @rohitgr7