Skip to content

Conversation

@manskx
Copy link
Contributor

@manskx manskx commented Jul 1, 2022

What does this PR do?

Adding the following cloud e2e tests to run apps on the cloud:

  • v0_app
  • boring_app
  • template_streamlit_ui
  • template_react_ui
  • template_jupyterlab
  • dle_timeout
  • collect_failures
  • custom_work_dependencies
  • drive
  • payload

To make run the tests, we need to have at least the following secrets:

LIGHTNING_CLOUD_URL: lightning cloud URL e.g. https://lightning.ai
LIGHTNING_USERNAME: lightning.ai username
LIGHTNING_USER_ID: lightning.ai user ID
LIGHTNING_API_KEY: lightning.ai API key

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda @tchaton @rohitgr7

@Borda Borda added priority: 1 Medium priority task ci Continuous Integration labels Jul 1, 2022
@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Jul 3, 2022
@manskx manskx marked this pull request as ready for review July 11, 2022 18:32
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Jul 12, 2022
@akihironitta akihironitta added the app (removed) Generic label for Lightning App package label Jul 13, 2022
@github-actions github-actions bot removed the app (removed) Generic label for Lightning App package label Jul 13, 2022
@manskx manskx marked this pull request as draft July 13, 2022 08:17
@manskx manskx force-pushed the add-ci-examples-e2e branch from 06b74f4 to 5969c1e Compare July 13, 2022 10:21
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's skip those tests with PL

@manskx manskx requested review from Borda and tchaton July 15, 2022 17:54
@manskx manskx requested a review from Borda July 16, 2022 10:55
@mergify mergify bot added the ready PRs ready to be merged label Jul 17, 2022
@Borda Borda added priority: 0 High priority task and removed priority: 1 Medium priority task labels Jul 17, 2022
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@Borda Borda requested a review from akihironitta July 17, 2022 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants