Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` #13688

jxtngx · 2022-07-16T23:05:18Z

What does this PR do?

Fix mypy errors attributed to pytorch_lightning.loggers.tensorboard.py for issue #13445

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

Was this discussed/approved via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

src/pytorch_lightning/loggers/tensorboard.py

awaelchli

LGTM

src/pytorch_lightning/loggers/tensorboard.py

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

for more information, see https://pre-commit.ci

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

src/pytorch_lightning/loggers/tensorboard.py

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

codecov · 2022-07-20T09:25:42Z

Codecov Report

Merging #13688 (7ccf7e7) into master (e451fa2) will decrease coverage by 10%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #13688     +/-   ##
=========================================
- Coverage      86%      76%    -10%     
=========================================
  Files         327      327             
  Lines       25485    25485             
=========================================
- Hits        21893    19445   -2448     
- Misses       3592     6040   +2448

…py` (#13688) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Rename GPUAccelerator to CUDAAccelerator * Add back GPUAccelerator and deprecate it * Remove temporary registration * accelerator connector reroute * accelerator_connector tests * update enums * lite support + tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * typo * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * move "gpu" support up before actual accelerator flag checks * Stupid arguments * fix tests * change exception type * fix registry test * pre-commit * CI: debug HPU flow (#13419) * Update the hpu-tests.yml to pull docker from vault * fire & sudo * habana-gaudi-hpus * Check the driver status on gaudi server (#13718) Co-authored-by: arao <arao@habana.ai> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Akarsha Rao <94624926+raoakarsha@users.noreply.github.com> * Update typing-extensions requirement from <4.2.1,>=4.0.0 to >=4.0.0,<4.3.1 in /requirements (#13529) Update typing-extensions requirement in /requirements Updates the requirements on [typing-extensions](https://github.com/python/typing_extensions) to permit the latest version. - [Release notes](https://github.com/python/typing_extensions/releases) - [Changelog](https://github.com/python/typing_extensions/blob/main/CHANGELOG.md) - [Commits](python/typing_extensions@4.0.0...4.3.0) --- updated-dependencies: - dependency-name: typing-extensions dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [pre-commit.ci] pre-commit suggestions (#13540) updates: - [github.com/psf/black: 22.3.0 → 22.6.0](psf/black@22.3.0...22.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * [FIX] Native FSDP precision + tests (#12985) * Simplify fetching's loader types (#13111) * Include app templates to the lightning and app packages (#13731) * Include app templates to the package Co-authored-by: mansy <mansy@lightning.ai> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Fix mypy typing errors in pytorch_lightning/callbacks/model_checkpoint.py (#13617) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Fix typos initialize in docs (#13557) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> * Fix main progress bar counter when `val_check_interval=int` and `check_val_every_n_epoch=None` (#12832) * Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` (#13688) Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> * Fix mypy errors attributed to `pytorch_lightning.loggers.mlflow` (#13691) Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: otaj <6065855+otaj@users.noreply.github.com> * fix mypy errors for loggers/wandb.py (#13483) Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com> * Fix gatekeeper minimum check (#13769) * changelog * changelog * fix order * move up again * add missing test Co-authored-by: rohitgr7 <rohitgr1998@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jirka Borovec <Borda@users.noreply.github.com> Co-authored-by: arao <arao@habana.ai> Co-authored-by: Akarsha Rao <94624926+raoakarsha@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sean Naren <sean@grid.ai> Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Mansy <ahmed.mansy156@gmail.com> Co-authored-by: mansy <mansy@lightning.ai> Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com> Co-authored-by: Lee Jungwon <33821003+BongYang@users.noreply.github.com> Co-authored-by: Nathaniel D'Amours <88633026+NathanielDamours@users.noreply.github.com> Co-authored-by: Justin Goheen <26209687+JustinGoheen@users.noreply.github.com> Co-authored-by: otaj <6065855+otaj@users.noreply.github.com> Co-authored-by: Gautier Dagan <s2234411@ed.ac.uk> Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>

remove module from pyproject.toml

81d1726

jxtngx changed the title ~~Fix mypy errors attributed to pytorch_lightning.loggers.tensorboard.py for issue #13445~~ Fix mypy errors attributed to pytorch_lightning.loggers.tensorboard.py Jul 16, 2022

jxtngx added 2 commits July 16, 2022 19:49

update type hints

9cfb09a

add ignore

9a5cd94

jxtngx marked this pull request as ready for review July 17, 2022 00:04

jxtngx requested review from Borda, SeanNaren, awaelchli, carmocca, justusschock, kaushikb11, rohitgr7, tchaton and williamFalcon as code owners July 17, 2022 00:04

otaj mentioned this pull request Jul 18, 2022

Improve typing coverage (4/n) #13445

Closed

52 tasks

otaj added this to the pl:1.7 milestone Jul 18, 2022

otaj added the code quality label Jul 18, 2022

otaj reviewed Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

awaelchli suggested changes Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

rohitgr7 reviewed Jul 18, 2022

View reviewed changes

jxtngx and others added 6 commits July 18, 2022 11:23

Update src/pytorch_lightning/loggers/tensorboard.py

189b860

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Update src/pytorch_lightning/loggers/tensorboard.py

2dbd734

Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>

Update src/pytorch_lightning/loggers/tensorboard.py

3a9fad5

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

Update src/pytorch_lightning/loggers/tensorboard.py

050acf2

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

[pre-commit.ci] auto fixes from pre-commit.com hooks

3670ee0

for more information, see https://pre-commit.ci

Update src/pytorch_lightning/loggers/tensorboard.py

10162ce

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

carmocca approved these changes Jul 18, 2022

View reviewed changes

src/pytorch_lightning/loggers/tensorboard.py Outdated Show resolved Hide resolved

jxtngx and others added 3 commits July 18, 2022 16:02

make save_dir req'd

eca640a

Update src/pytorch_lightning/loggers/tensorboard.py

2f4254a

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

Tensor

c523aca

Borda requested review from awaelchli, otaj and rohitgr7 July 18, 2022 21:00

Borda approved these changes Jul 18, 2022

View reviewed changes

awaelchli approved these changes Jul 19, 2022

View reviewed changes

mergify bot added the ready PRs ready to be merged label Jul 19, 2022

akihironitta approved these changes Jul 19, 2022

View reviewed changes

otaj enabled auto-merge (squash) July 19, 2022 07:17

otaj approved these changes Jul 19, 2022

View reviewed changes

carmocca added the community This PR is from the community label Jul 19, 2022

carmocca assigned otaj Jul 19, 2022

Merge branch 'master' into codeq/tensorboard-logger

5c5a86d

github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 20, 2022

otaj and others added 3 commits July 20, 2022 17:45

Merge branch 'master' into codeq/tensorboard-logger

c8c096f

empty

894a623

Merge branch 'master' into codeq/tensorboard-logger

7ccf7e7

otaj merged commit 3474626 into Lightning-AI:master Jul 21, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` #13688

Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` #13688

Uh oh!

jxtngx commented Jul 16, 2022 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

awaelchli left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 20, 2022 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix mypy errors attributed to pytorch_lightning.loggers.tensorboard.py #13688

Fix mypy errors attributed to pytorch_lightning.loggers.tensorboard.py #13688

Uh oh!

Conversation

jxtngx commented Jul 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

PR review

Did you have fun?

Uh oh!

Uh oh!

Uh oh!

awaelchli left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Jul 20, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` #13688

Fix mypy errors attributed to `pytorch_lightning.loggers.tensorboard.py` #13688

jxtngx commented Jul 16, 2022 •

edited

Loading

codecov bot commented Jul 20, 2022 •

edited

Loading