Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 19, 2022

What does this PR do?

prune requirements which are already defined in lightning-cloud

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@Borda Borda added the app (removed) Generic label for Lightning App package label Jul 19, 2022
@Borda Borda added this to the app:0.5.x milestone Jul 19, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 20, 2022
@akihironitta akihironitta enabled auto-merge (squash) July 23, 2022 11:03
@akihironitta akihironitta merged commit e2ec51a into master Jul 23, 2022
@akihironitta akihironitta deleted the req/app branch July 23, 2022 11:17
Borda added a commit that referenced this pull request Jul 25, 2022
prune requirements

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
(cherry picked from commit e2ec51a)
lexierule pushed a commit that referenced this pull request Jul 25, 2022
prune requirements

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
(cherry picked from commit e2ec51a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants