Skip to content

Set default strategy to ddp_fork in interactive environments #13746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 22, 2022
Merged

Set default strategy to ddp_fork in interactive environments #13746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0272685
Set default strategy to ddp_fork in interactive environments
awaelchli Jul 20, 2022
141eeea
update
awaelchli Jul 20, 2022
b14786e
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 20, 2022
68674e4
Merge branch 'master' into feature/ddp-fork2-autodetect2
awaelchli Jul 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pytorch_lightning/trainer/connectors/accelerator_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@
_HOROVOD_AVAILABLE,
_HPU_AVAILABLE,
_IPU_AVAILABLE,
_IS_INTERACTIVE,
_TORCH_GREATER_EQUAL_1_11,
_TPU_AVAILABLE,
)
Expand Down Expand Up @@ -588,7 +589,9 @@ def _choose_strategy(self) -> Union[Strategy, str]:
# TODO: lazy initialized device, then here could be self._strategy_flag = "single_device"
return SingleDeviceStrategy(device=device) # type: ignore
if len(self._parallel_devices) > 1:
return DDPSpawnStrategy.strategy_name
if _IS_INTERACTIVE:
return "ddp_fork"
return "ddp_spawn"

return DDPStrategy.strategy_name

Expand Down
12 changes: 12 additions & 0 deletions tests/tests_pytorch/accelerators/test_accelerator_connector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,18 @@ def test_strategy_choice_ddp_spawn_cpu():
assert trainer.strategy.launcher._start_method == "spawn"


@RunIf(skip_windows=True)
@mock.patch("pytorch_lightning.trainer.connectors.accelerator_connector._IS_INTERACTIVE", True)
def test_strategy_choice_ddp_fork_in_interactive():
"""Test that when accelerator and strategy are unspecified, the connector chooses DDP Fork in interactive
environments by default."""
trainer = Trainer(devices=2)
assert isinstance(trainer.accelerator, CPUAccelerator)
assert isinstance(trainer.strategy, DDPSpawnStrategy)
assert isinstance(trainer.strategy.cluster_environment, LightningEnvironment)
assert trainer.strategy.launcher._start_method == "fork"


@RunIf(skip_windows=True)
def test_strategy_choice_ddp_fork_cpu():
trainer = Trainer(strategy="ddp_fork", accelerator="cpu", devices=2)
Expand Down