Skip to content

Conversation

@manskx
Copy link
Contributor

@manskx manskx commented Jul 21, 2022

What does this PR do?

In the component template, the pyhton version is not fully supported by the framework. Pyhton 3.8 is supported and well tested with the framework.

This PR updates the CI to use the correct python version

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda

@manskx manskx added the app:cli label Jul 21, 2022
@manskx manskx self-assigned this Jul 21, 2022
@manskx manskx marked this pull request as ready for review July 21, 2022 15:30
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mergify mergify bot added the ready PRs ready to be merged label Jul 22, 2022
@mergify mergify bot requested a review from a team July 22, 2022 10:48
@manskx manskx enabled auto-merge (squash) July 22, 2022 11:09
@manskx manskx added this to the app:0.5.x milestone Jul 22, 2022
@manskx manskx merged commit 4588a79 into master Jul 22, 2022
@manskx manskx deleted the lai2-9653-lightning-init-component-failing branch July 22, 2022 11:38
Borda pushed a commit that referenced this pull request Jul 25, 2022
use correct python version in lightning component template

Co-authored-by: manskx <ahmed.mansy156@gmail.com>
(cherry picked from commit 4588a79)
lexierule pushed a commit that referenced this pull request Jul 25, 2022
use correct python version in lightning component template

Co-authored-by: manskx <ahmed.mansy156@gmail.com>
(cherry picked from commit 4588a79)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants