Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Jul 27, 2022

What does this PR do?

Add clarification/explanation to each requirement file so we keep it in mind

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@Borda Borda added the docs Documentation related label Jul 27, 2022
@codecov
Copy link

codecov bot commented Jul 27, 2022

Codecov Report

Merging #13872 (fcc2697) into master (5f1cb91) will increase coverage by 6%.
The diff coverage is n/a.

❗ Current head fcc2697 differs from pull request most recent head 6f26d0c. Consider uploading reports for the commit 6f26d0c to get more accurate results

@@            Coverage Diff             @@
##           master   #13872      +/-   ##
==========================================
+ Coverage      80%      86%      +6%     
==========================================
  Files         103      333     +230     
  Lines        6833    26159   +19326     
==========================================
+ Hits         5446    22492   +17046     
- Misses       1387     3667    +2280     

@Borda Borda requested a review from carmocca July 27, 2022 21:01
@Borda Borda modified the milestones: pl:1.6.x, all:next Jul 28, 2022
@mergify mergify bot removed the has conflicts label Jul 28, 2022
@mergify mergify bot added the ready PRs ready to be merged label Jul 28, 2022
Borda and others added 2 commits July 29, 2022 12:23
Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>
@mergify mergify bot added has conflicts and removed ready PRs ready to be merged labels Aug 3, 2022
@mergify mergify bot added ready PRs ready to be merged and removed has conflicts labels Aug 3, 2022
@mergify mergify bot added ready PRs ready to be merged and removed ready PRs ready to be merged labels Aug 3, 2022
@Borda Borda mentioned this pull request Aug 3, 2022
12 tasks
@Borda Borda enabled auto-merge (squash) August 3, 2022 21:04
@Borda Borda merged commit e513638 into master Aug 3, 2022
@Borda Borda deleted the req/notes branch August 3, 2022 21:43
Borda added a commit that referenced this pull request Aug 9, 2022
* adding explain notes for requirements
* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit e513638)
lexierule pushed a commit that referenced this pull request Aug 9, 2022
* adding explain notes for requirements
* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit e513638)
awaelchli added a commit that referenced this pull request Aug 9, 2022
* adding explain notes for requirements
* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit e513638)
awaelchli added a commit that referenced this pull request Aug 9, 2022
* adding explain notes for requirements
* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit e513638)
lexierule pushed a commit that referenced this pull request Aug 9, 2022
* adding explain notes for requirements
* Apply suggestions from code review

Co-authored-by: Rohit Gupta <rohitgr1998@gmail.com>

(cherry picked from commit e513638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants