Skip to content

Conversation

@akihironitta
Copy link
Contributor

@akihironitta akihironitta commented Jul 31, 2022

What does this PR do?

Fixes #13946.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @rohitgr7 @akihironitta @justusschock

@akihironitta akihironitta added bug Something isn't working accelerator: mps Apple Silicon GPU labels Jul 31, 2022
@akihironitta akihironitta added this to the pl:1.7.x milestone Jul 31, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jul 31, 2022
@carmocca carmocca modified the milestones: pl:1.7.x, pl:1.6.x Jul 31, 2022
@carmocca carmocca added the priority: 0 High priority task label Jul 31, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 1, 2022
@kaushikb11
Copy link
Contributor

@akihironitta Could you confirm it with author of the issue before merging it? Thanks!

@akihironitta
Copy link
Contributor Author

@akihironitta Could you confirm it with author of the issue before merging it? Thanks!

I've confirmed it works locally on my machine but will do so to double-check the behaviour :)


Hi @adamgayoso, thank you for reporting the issue! Could you also check if it works as expected with the patch?

- _MPS_AVAILABLE = _TORCH_GREATER_EQUAL_1_12 and torch.backends.mps.is_available() and platform.platform() == "arm"
+ _MPS_AVAILABLE = _TORCH_GREATER_EQUAL_1_12 and torch.backends.mps.is_available() and platform.processor() == "arm"

@adamgayoso
Copy link

This will work!

@rohitgr7 rohitgr7 enabled auto-merge (squash) August 2, 2022 09:18
@awaelchli awaelchli modified the milestones: pl:1.6.x, pl:1.7 Aug 2, 2022
@rohitgr7 rohitgr7 merged commit af07e75 into master Aug 2, 2022
@rohitgr7 rohitgr7 deleted the bugfix/mps-availability branch August 2, 2022 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accelerator: mps Apple Silicon GPU bug Something isn't working pl Generic label for PyTorch Lightning package priority: 0 High priority task ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Platform check incorrect on M1 pro device

7 participants