Skip to content

Conversation

@hhsecond
Copy link

@hhsecond hhsecond commented Aug 12, 2022

What does this PR do?

Work's resource specification was wrong in the document. This PR fixes it to match the current cloud configuration

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Aug 12, 2022
@hhsecond hhsecond marked this pull request as ready for review August 12, 2022 11:31
@hhsecond hhsecond added the docs Documentation related label Aug 12, 2022
@awaelchli awaelchli added this to the app:0.6 milestone Aug 12, 2022
@awaelchli awaelchli requested a review from manskx August 15, 2022 11:05
@mergify mergify bot added the ready PRs ready to be merged label Aug 15, 2022
@awaelchli awaelchli enabled auto-merge (squash) August 15, 2022 12:58
@awaelchli awaelchli merged commit deaadc1 into master Aug 15, 2022
@awaelchli awaelchli deleted the doc-fix-for-defaultWork-cpu branch August 15, 2022 13:35
Borda pushed a commit that referenced this pull request Aug 16, 2022
lexierule pushed a commit that referenced this pull request Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants