Skip to content

Fixed WandbLogger save_dir is not set after creation (#12748) #14326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Fixed WandbLogger save_dir is not set after creation (#12748) #14326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b5933f9
Fix wandb save_dir is None (#12748)
tshu-w Aug 16, 2022
963298f
add a test
tshu-w Sep 3, 2022
e9552c5
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 3, 2022
f25d522
Merge branch 'master' into fix-12748
Borda Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pytorch_lightning/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed an issue to keep downscaling the batch size in case there hasn't been even a single successful optimal batch size with `mode="power"` ([#14372](https://github.com/Lightning-AI/lightning/pull/14372))


- Fixed `WandbLogger` `save_dir` is not set after creation ([#14326](https://github.com/Lightning-AI/lightning/pull/14326))



## [1.7.4] - 2022-08-31

Expand All @@ -162,9 +165,6 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Fixed an issue to avoid the impact of sanity check on `reload_dataloaders_every_n_epochs` for validation ([#13964](https://github.com/Lightning-AI/lightning/pull/13964))


- Fixed `Trainer.estimated_stepping_batches` when maximum number of epochs is not set ([#14317](https://github.com/Lightning-AI/lightning/pull/14317))


## [1.7.2] - 2022-08-17

### Added
Expand Down
6 changes: 3 additions & 3 deletions src/pytorch_lightning/loggers/wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def __init__(self, *args, **kwarg):

Args:
name: Display name for the run.
save_dir: Path where data is saved (wandb dir by default).
save_dir: Path where data is saved.
offline: Run offline (data can be streamed later to wandb servers).
id: Sets the version, mainly used to resume a previous run.
version: Same as id.
Expand Down Expand Up @@ -255,7 +255,7 @@ def __init__(self, *args, **kwarg):
def __init__(
self,
name: Optional[str] = None,
save_dir: Optional[str] = None,
save_dir: str = ".",
offline: bool = False,
id: Optional[str] = None,
anonymous: Optional[bool] = None,
Expand Down Expand Up @@ -300,7 +300,7 @@ def __init__(
name=name,
project=project,
id=version or id,
dir=save_dir,
dir=save_dir or kwargs.pop("dir"),
resume="allow",
anonymous=("allow" if anonymous else None),
)
Expand Down
8 changes: 7 additions & 1 deletion tests/tests_pytorch/loggers/test_wandb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,15 @@ def test_wandb_logger_init(wandb, monkeypatch):
wandb.init.reset_mock()
WandbLogger(project="test_project").experiment
wandb.init.assert_called_once_with(
name=None, dir=None, id=None, project="test_project", resume="allow", anonymous=None
name=None, dir=".", id=None, project="test_project", resume="allow", anonymous=None
)

# test wandb.init set save_dir correctly after created
wandb.run = None
wandb.init.reset_mock()
logger = WandbLogger(project="test_project")
assert logger.save_dir is not None

# test wandb.init and setting logger experiment externally
wandb.run = None
run = wandb.init()
Expand Down