Skip to content

Conversation

@williamFalcon
Copy link
Contributor

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

What does this PR do?

Fixes # (issue).

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@mergify mergify bot requested a review from a team April 9, 2020 18:34
@williamFalcon williamFalcon changed the title workers warning not on windows keyboard crash info from proc_zero only Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #1433 into master will increase coverage by 0%.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master   #1433   +/-   ##
======================================
  Coverage      92%     92%           
======================================
  Files          66      66           
  Lines        3508    3509    +1     
======================================
+ Hits         3212    3213    +1     
  Misses        296     296           

@williamFalcon williamFalcon merged commit 2dec93f into master Apr 9, 2020
@Borda Borda added the bug Something isn't working label Apr 9, 2020
@Borda Borda added this to the 0.7.3 milestone Apr 9, 2020
@Borda Borda deleted the info branch April 9, 2020 18:50
@Borda Borda modified the milestones: 0.7.4, 0.7.3 Apr 10, 2020
tullie pushed a commit to tullie/pytorch-lightning that referenced this pull request Jun 7, 2020
@Borda Borda modified the milestones: 0.7.3, v0.7.x Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants