Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 22, 2022

What does this PR do?

update notebooks git submodule update --remote

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7

@Borda Borda added the docs Documentation related label Aug 22, 2022
@rohitgr7
Copy link
Contributor

since these notebook are part of the docs, should we automate this during release only?

@Borda
Copy link
Collaborator Author

Borda commented Aug 22, 2022

since these notebook are part of the docs, should we automate this during release only?

Good point with pull update only for release... we would just need to not forget :)

@Borda Borda added this to the all:next milestone Aug 23, 2022
@Borda Borda self-assigned this Aug 26, 2022
@mergify mergify bot added the ready PRs ready to be merged label Aug 29, 2022
@Borda Borda enabled auto-merge (squash) August 29, 2022 20:55
@Borda Borda merged commit 7987a1b into master Aug 30, 2022
@Borda Borda deleted the docs/notebooks branch August 30, 2022 12:12
rohitgr7 pushed a commit that referenced this pull request Aug 31, 2022
lexierule pushed a commit that referenced this pull request Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants