Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 26, 2022

What does this PR do?

The job names are quite duplicated, and if they need to be set as required checks, it is very hard to determine which are the missing checks; see below:

image

NOTE: This will need an update of the required checks

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@Borda Borda added the ci Continuous Integration label Aug 26, 2022
@Borda Borda added this to the all:next milestone Aug 26, 2022
@carmocca carmocca changed the title update CJ job names Update GHA job names Aug 26, 2022
Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
@mergify mergify bot added the ready PRs ready to be merged label Aug 26, 2022
Borda and others added 2 commits August 26, 2022 19:25
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda Borda self-assigned this Aug 26, 2022
@Borda Borda merged commit 80b1987 into master Aug 29, 2022
@Borda Borda deleted the ci/names branch August 29, 2022 18:03
rohitgr7 pushed a commit that referenced this pull request Aug 31, 2022
* update CJ job names
* groups
* filter
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
lexierule pushed a commit that referenced this pull request Aug 31, 2022
* update CJ job names
* groups
* filter
* Apply suggestions from code review

Co-authored-by: Akihiro Nitta <nitta@akihironitta.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants