Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 30, 2022

What does this PR do?

As spoken with @carmocca seems that the group probot did not worked as intended yet, work will continue in another PR...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added ci Continuous Integration priority: 1 Medium priority task labels Aug 30, 2022
@Borda Borda added this to the pl:future milestone Aug 30, 2022
@akihironitta akihironitta mentioned this pull request Aug 30, 2022
12 tasks
@mergify mergify bot added the ready PRs ready to be merged label Aug 30, 2022
@lexierule lexierule merged commit 6188593 into master Aug 30, 2022
@lexierule lexierule deleted the ci/probot branch August 30, 2022 17:38
carmocca added a commit that referenced this pull request Sep 1, 2022
@carmocca carmocca modified the milestones: pl:future, pl:1.7.x, pl:1.8 Sep 2, 2022
@Borda Borda self-assigned this Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration priority: 1 Medium priority task ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants