Skip to content

Conversation

@awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Sep 7, 2022

What does this PR do?

The tests were in the wrong file and can be moved to test_device_parser.py.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

cc @carmocca @justusschock @awaelchli @Borda @akihironitta

@awaelchli awaelchli added fabric lightning.fabric.Fabric tests labels Sep 7, 2022
@awaelchli awaelchli self-assigned this Sep 7, 2022
@awaelchli awaelchli added this to the pl:1.8 milestone Sep 7, 2022
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 7, 2022
@mergify mergify bot added the ready PRs ready to be merged label Sep 7, 2022
@carmocca carmocca enabled auto-merge (squash) September 7, 2022 20:07
@carmocca carmocca merged commit 9537444 into master Sep 7, 2022
@carmocca carmocca deleted the lite/tests/device-parser branch September 7, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants