Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 9, 2022

What does this PR do?

LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@Borda Borda added bug Something isn't working priority: 0 High priority task ci Continuous Integration labels Sep 9, 2022
@Borda Borda added this to the all:next milestone Sep 9, 2022
@Borda Borda requested a review from a team September 9, 2022 17:50
@Borda Borda enabled auto-merge (squash) September 9, 2022 17:51
@mergify mergify bot added the ready PRs ready to be merged label Sep 9, 2022
@Borda Borda merged commit 7cbf153 into master Sep 9, 2022
@Borda Borda deleted the ci/last-pkg branch September 9, 2022 18:38
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
krshrimali pushed a commit that referenced this pull request Sep 13, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
lexierule pushed a commit that referenced this pull request Sep 13, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
lexierule pushed a commit that referenced this pull request Sep 19, 2022
LooseVersion was not correctly evaluation RC and set it as last even though the full release is out...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration priority: 0 High priority task ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants