Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Sep 16, 2022

What does this PR do?

The rc and dev shall not be skipped
I believe this is the proper fix for #14750

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

Copy link
Contributor

@otaj otaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say, I have no idea how come this works and it wasn't working before #14750, because this is essentially revert of #14750, but it seems it works (the checks are passing 👍)

@Borda Borda added bug Something isn't working ci Continuous Integration labels Sep 16, 2022
@Borda Borda self-assigned this Sep 16, 2022
@Borda
Copy link
Collaborator Author

Borda commented Sep 16, 2022

I have to say, I have no idea how come this works and it wasn't working before #14750, because this is essentially revert of #14750, but it seems it works (the checks are passing +1)

I agree that it is strange that it did not work, but it was working fine on master all the time... 🦦
so could we miss a cherry-pick from master? 🐰

@Borda Borda enabled auto-merge (squash) September 16, 2022 15:25
@mergify mergify bot added the ready PRs ready to be merged label Sep 16, 2022
@Borda Borda added this to the all:next milestone Sep 16, 2022
@Borda Borda merged commit d9be959 into master Sep 16, 2022
@Borda Borda deleted the ci/keep-rc branch September 16, 2022 18:11
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
krshrimali pushed a commit that referenced this pull request Sep 16, 2022
lexierule pushed a commit that referenced this pull request Sep 19, 2022
kaushikb11 pushed a commit that referenced this pull request Sep 21, 2022
carmocca pushed a commit that referenced this pull request Sep 21, 2022
carmocca pushed a commit that referenced this pull request Sep 21, 2022
lexierule pushed a commit that referenced this pull request Sep 22, 2022
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci Continuous Integration ready PRs ready to be merged

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants