Skip to content

Fix icon encoding in PL App pretty-print #14795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Sep 20, 2022
Merged

Fix icon encoding in PL App pretty-print #14795

merged 10 commits into from
Sep 20, 2022

Conversation

@christopher-nguyen-re
Copy link
Contributor

@christopher-nguyen-re christopher-nguyen-re commented Sep 20, 2022 •
edited by awaelchli
Loading

What does this PR do?

This PR aims to fix broken CLI output for some terminals. I added a test in tests/tests_app/cli/test_cli.py but am unsure if it is an effective one. I will need to verify that this works on terminals addressed by @awaelchli.

Fixes #14226

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Yes! This was a fun first experience.

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 20, 2022
awaelchli
awaelchli reviewed Sep 20, 2022
View reviewed changes
awaelchli
awaelchli reviewed Sep 20, 2022
View reviewed changes
@awaelchli awaelchli self-assigned this Sep 20, 2022
@awaelchli awaelchli added community This PR is from the community bug Something isn't working labels Sep 20, 2022
@awaelchli awaelchli added this to the app:0.6.x milestone Sep 20, 2022
awaelchli
awaelchli approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!
I improved the test, take a look.

@awaelchli awaelchli changed the title Bugfix/14226 cli output Fix icon encoding in PL App pretty-print Sep 20, 2022
@awaelchli awaelchli marked this pull request as ready for review September 20, 2022 13:22
@mergify mergify bot added the ready PRs ready to be merged label Sep 20, 2022
tchaton
tchaton approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome ! Great contribution 1

@awaelchli awaelchli merged commit 0841f23 into Lightning-AI:master Sep 20, 2022
Borda pushed a commit that referenced this pull request Sep 20, 2022
@christopher-nguyen-re @Borda
Fix icon encoding in PL App pretty-print (#14795)
ab8e9f6 
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>

(cherry picked from commit 0841f23)
lexierule pushed a commit that referenced this pull request Sep 22, 2022
@christopher-nguyen-re @lexierule
Fix icon encoding in PL App pretty-print (#14795)
445e426 
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>

(cherry picked from commit 0841f23)
rohitgr7 pushed a commit that referenced this pull request Sep 24, 2022
@christopher-nguyen-re @awaelchli @rohitgr7
Fix icon encoding in PL App pretty-print (#14795)
e37d5bd 
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanwharris ethanwharris ethanwharris approved these changes

@tchaton tchaton tchaton approved these changes

@manskx manskx Awaiting requested review from manskx

@hhsecond hhsecond Awaiting requested review from hhsecond

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

+2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@awaelchli awaelchli

Labels

app (removed) Generic label for Lightning App package bug Something isn't working community This PR is from the community ready PRs ready to be merged

Projects

No open projects
Frameworks Planning
Status: Done

Milestone

app:0.6.x

Development

Successfully merging this pull request may close these issues.

Icons in PL app CLI output broken in some terminals

5 participants

@christopher-nguyen-re @awaelchli @ethanwharris @carmocca @tchaton