Skip to content

Conversation

@manskx
Copy link
Contributor

@manskx manskx commented Oct 21, 2022

What does this PR do?

This PR deletes apps in the CI account that are older than 1 hour. This account is used for CI tests only so no test should run for more than one hour.

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @carmocca @akihironitta @Borda

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Oct 21, 2022
@manskx manskx marked this pull request as ready for review October 21, 2022 12:33
@manskx manskx changed the title delete apps older than 1 hours CI account Delete apps older than 1 hours CI account Oct 21, 2022
@manskx manskx changed the title Delete apps older than 1 hours CI account [App][CI] Delete apps older than 1 hours CI account Oct 21, 2022
@awaelchli awaelchli added the ci Continuous Integration label Oct 22, 2022
@awaelchli awaelchli added this to the v1.8.x milestone Oct 22, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 22, 2022
@manskx manskx enabled auto-merge (squash) October 24, 2022 18:38
@Borda
Copy link
Collaborator

Borda commented Oct 25, 2022

@tchaton, mind checking this one? 🦦

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@manskx
Copy link
Contributor Author

manskx commented Oct 31, 2022

@lantiga I need your review to merge this

@manskx manskx disabled auto-merge October 31, 2022 09:45
@manskx manskx enabled auto-merge (squash) October 31, 2022 09:56
@manskx manskx disabled auto-merge October 31, 2022 09:57
@awaelchli awaelchli enabled auto-merge (squash) October 31, 2022 18:47
@awaelchli awaelchli merged commit 4a4b7f3 into master Oct 31, 2022
@awaelchli awaelchli deleted the manskx/app/ci/clean-old-apps branch October 31, 2022 19:47
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package ci Continuous Integration ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants