Skip to content

Conversation

@kaushikb11
Copy link
Contributor

@kaushikb11 kaushikb11 commented Oct 31, 2022

What does this PR do?

Update notebooks

git submodule update --remote

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @rohitgr7 @Felonious-Spellfire

@kaushikb11 kaushikb11 added the docs Documentation related label Oct 31, 2022
@akihironitta akihironitta added this to the v1.9 milestone Oct 31, 2022
@mergify mergify bot added the ready PRs ready to be merged label Oct 31, 2022
@rohitgr7 rohitgr7 merged commit b429da9 into master Oct 31, 2022
@rohitgr7 rohitgr7 deleted the update/submodule branch October 31, 2022 19:13
@Borda Borda modified the milestones: v1.9, v1.8.x Nov 1, 2022
@carmocca carmocca modified the milestones: v1.8.x, v1.8 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants