Skip to content

Conversation

@awaelchli
Copy link
Contributor

What does this PR do?

Unblocks merging to master. The meta package or something in the CI using it is broken, our testing shows it.

At least one PR is blocked by this:
#15301 test failures

Changes reflected in lightning_lite are not reflected in PL which has it as dependency. Someone more skilled than me will fix it.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@Borda
Copy link
Collaborator

Borda commented Nov 1, 2022

Seems like examples while testing lightning package has not been updated with replacement for PL by lightning.pytorch

Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix shall be with pkg replace in examples

@awaelchli awaelchli closed this Nov 1, 2022
@awaelchli awaelchli deleted the ci/disable-meta-tests branch November 1, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants