Skip to content

Clarify cluster advanced docs #16403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 17, 2023
Merged

Clarify cluster advanced docs #16403

merged 2 commits into from
Jan 17, 2023

Conversation

@carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 17, 2023 •
edited by github-actions bot
Loading

What does this PR do?

LightningTemplateModel does not exist.

An user thought this was an existing module that he had to import.

Does your PR introduce any breaking changes? If yes, please list them.

None

cc @Borda

@carmocca carmocca added the docs Documentation related label Jan 17, 2023
@carmocca carmocca added this to the v1.9 milestone Jan 17, 2023
@carmocca carmocca self-assigned this Jan 17, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Jan 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2023 •
edited
Loading

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success ✅
make-html (pytorch) success ✅

These checks are required after the changes to docs/source-pytorch/clouds/cluster_advanced.rst.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda enabled auto-merge (squash) January 17, 2023 14:33
@mergify mergify bot added the ready PRs ready to be merged label Jan 17, 2023
@Borda Borda merged commit cfe87a0 into master Jan 17, 2023
@Borda Borda deleted the docs/clarify-cluster branch January 17, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Borda Borda Borda approved these changes

@edenlightning edenlightning Awaiting requested review from edenlightning

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

+1 more reviewer

@awaelchli awaelchli awaelchli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@carmocca carmocca

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

3 participants

@carmocca @awaelchli @Borda