Skip to content

Fix imports for lightning cli examples #16871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2023
Merged

Fix imports for lightning cli examples #16871

merged 1 commit into from
Feb 25, 2023

Conversation

@dtuit
Copy link
Contributor

@dtuit dtuit commented Feb 25, 2023

What does this PR do?

Fixes imports for lightning cli examples

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Feb 25, 2023
@awaelchli awaelchli added docs Documentation related lightningcli pl.cli.LightningCLI community This PR is from the community labels Feb 25, 2023
@awaelchli awaelchli added this to the 2.0 milestone Feb 25, 2023
@awaelchli awaelchli changed the title fix imports for lightning cli examples Fix imports for lightning cli examples Feb 25, 2023
awaelchli
awaelchli approved these changes Feb 25, 2023
View reviewed changes
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 💜

@carmocca carmocca merged commit cdf21a1 into Lightning-AI:master Feb 25, 2023
@mergify mergify bot added the ready PRs ready to be merged label Feb 25, 2023
carmocca pushed a commit that referenced this pull request Feb 27, 2023
@dtuit @carmocca
Fix imports for lightning cli examples (#16871)
70de140
@carmocca carmocca modified the milestones: 2.0, v1.9.x Feb 27, 2023
lexierule pushed a commit that referenced this pull request Feb 28, 2023
@dtuit @lexierule
Fix imports for lightning cli examples (#16871)
058dd9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@edenlightning edenlightning Awaiting requested review from edenlightning

@lantiga lantiga Awaiting requested review from lantiga lantiga is a code owner

@Borda Borda Awaiting requested review from Borda

2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

community This PR is from the community docs Documentation related lightningcli pl.cli.LightningCLI pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Milestone

v1.9.x

Development

Successfully merging this pull request may close these issues.

3 participants

@dtuit @awaelchli @carmocca