New fabric parity tests #16899
Merged
New fabric parity tests #16899
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 436a5e6.
for more information, see https://pre-commit.ci
justusschock
approved these changes
Mar 4, 2023
carmocca
reviewed
Mar 6, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
for more information, see https://pre-commit.ci
…fabric/framework-overhead
carmocca
approved these changes
Mar 6, 2023
Borda
pushed a commit
that referenced
this pull request
Mar 30, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com> Co-authored-by: Jirka <jirka.borovec@seznam.cz> (cherry picked from commit 3e04353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rewrite of all parity tests. Cleaner and easier to read.
Since these tests don't run on an isolated system, there will be noise from other tasks that can lead to flakiness in the assertions for timings we make. To mitigate this, we rerun the test up to 3 times if it fails.
Each test runs for about 8 seconds, 1000 training iterations. This is to ensure we get a robust measurement.
cc @carmocca @justusschock @awaelchli @Borda