Organize app examples #17045

awaelchli · 2023-03-13T00:39:01Z

What does this PR do?

Moves the app examples under examples/app for easier navigation when exploring the examples folder.

Before:

examples/app_boring
examples/app_components
...

Now:

examples/app/boring
examples/app/components
...

Fixes #16273
Closes #17073

cc @Borda @carmocca @akihironitta @justusschock @awaelchli

github-actions · 2023-03-13T00:42:20Z

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py, tests/tests_app/cli/jsons/connect_1.json.

🟢 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	success	✅
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to .github/workflows/ci-examples-app.yml, src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py, tests/integrations_app/public/__init__.py, tests/integrations_app/public/test_app_dag.py, tests/integrations_app/public/test_argparse.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_drive.py, tests/integrations_app/public/test_gradio.py, tests/integrations_app/public/test_installation_commands_app.py, tests/integrations_app/public/test_layout.py, tests/integrations_app/public/test_multi_node.py, tests/integrations_app/public/test_payload.py, tests/integrations_app/public/test_pickle_or_not.py, tests/integrations_app/public/test_scripts.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py, tests/integrations_app/public/test_v0_app.py, examples/app/argparse/app.py, examples/app/boring/app.py, examples/app/boring/app_dynamic.py, examples/app/boring/scripts/__init__.py, examples/app/boring/scripts/serve.py, examples/app/commands_and_api/app.py, examples/app/commands_and_api/command.py, examples/app/components/python/__init__.py, examples/app/components/python/app.py, examples/app/components/python/component_popen.py, examples/app/components/python/component_tracer.py, examples/app/components/python/pl_script.py, examples/app/components/serve/gradio/app.py, examples/app/components/serve/gradio/beyonce.jpg, examples/app/components/serve/gradio/requirements.txt, examples/app/dag/app.py, examples/app/dag/processing.py, examples/app/dag/requirements.txt, examples/app/display_name/app.py, examples/app/drive/app.py, examples/app/hpo/app_wi_ui.py, examples/app/hpo/app_wo_ui.py, examples/app/hpo/download_data.py, examples/app/hpo/hyperplot.py, examples/app/hpo/objective.py, examples/app/hpo/pl_script.py, examples/app/hpo/requirements.txt, examples/app/hpo/utils.py, examples/app/installation_commands/app.py, examples/app/interruptible/app.py, examples/app/justpy/app.py, examples/app/justpy/requirements.txt, examples/app/layout/app.py, examples/app/layout/requirements.txt, examples/app/layout/ui1/index.html, examples/app/layout/ui2/index.html, examples/app/mount/app.py, examples/app/multi_node/pl_boring_script.py, examples/app/multi_node/requirements.txt, examples/app/multi_node/train_any.py, examples/app/multi_node/train_fabric.py, examples/app/multi_node/train_lt.py, examples/app/multi_node/train_lt_script.py, examples/app/multi_node/train_pytorch.py, examples/app/multi_node/train_pytorch_spawn.py, examples/app/payload/app.py, examples/app/pickle_or_not/app.py, examples/app/pickle_or_not/requirements.txt, examples/app/server/app.py, examples/app/server_with_auto_scaler/app.py, examples/app/template_streamlit_ui/app.py, examples/app/template_streamlit_ui/requirements.txt, examples/app/v0/app.py, examples/app/v0/emulate_ui.py, examples/app/v0/requirements.txt, examples/app/v0/ui/a/index.html, examples/app/v0/ui/b/index.html, examples/app/works_on_default_machine/app_v2.py, examples/app/works_on_default_machine/requirements.txt.

🟢 lightning_app: Azure

Check ID	Status
App.cloud-e2e	success	✅

These checks are required after the changes to .azure/app-cloud-e2e.yml, src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py, examples/app/argparse/app.py, examples/app/boring/app.py, examples/app/boring/app_dynamic.py, examples/app/boring/scripts/__init__.py, examples/app/boring/scripts/serve.py, examples/app/commands_and_api/app.py, examples/app/commands_and_api/command.py, examples/app/components/python/__init__.py, examples/app/components/python/app.py, examples/app/components/python/component_popen.py, examples/app/components/python/component_tracer.py, examples/app/components/python/pl_script.py, examples/app/components/serve/gradio/app.py, examples/app/components/serve/gradio/beyonce.jpg, examples/app/components/serve/gradio/requirements.txt, examples/app/dag/app.py, examples/app/dag/processing.py, examples/app/dag/requirements.txt, examples/app/display_name/app.py, examples/app/drive/app.py, examples/app/hpo/app_wi_ui.py, examples/app/hpo/app_wo_ui.py, examples/app/hpo/download_data.py, examples/app/hpo/hyperplot.py, examples/app/hpo/objective.py, examples/app/hpo/pl_script.py, examples/app/hpo/requirements.txt, examples/app/hpo/utils.py, examples/app/installation_commands/app.py, examples/app/interruptible/app.py, examples/app/justpy/app.py, examples/app/justpy/requirements.txt, examples/app/layout/app.py, examples/app/layout/requirements.txt, examples/app/layout/ui1/index.html, examples/app/layout/ui2/index.html, examples/app/mount/app.py, examples/app/multi_node/pl_boring_script.py, examples/app/multi_node/requirements.txt, examples/app/multi_node/train_any.py, examples/app/multi_node/train_fabric.py, examples/app/multi_node/train_lt.py, examples/app/multi_node/train_lt_script.py, examples/app/multi_node/train_pytorch.py, examples/app/multi_node/train_pytorch_spawn.py, examples/app/payload/app.py, examples/app/pickle_or_not/app.py, examples/app/pickle_or_not/requirements.txt, examples/app/server/app.py, examples/app/server_with_auto_scaler/app.py, examples/app/template_streamlit_ui/app.py, examples/app/template_streamlit_ui/requirements.txt, examples/app/v0/app.py, examples/app/v0/emulate_ui.py, examples/app/v0/requirements.txt, examples/app/v0/ui/a/index.html, examples/app/v0/ui/b/index.html, examples/app/works_on_default_machine/app_v2.py, examples/app/works_on_default_machine/requirements.txt, tests/integrations_app/public/__init__.py, tests/integrations_app/public/test_app_dag.py, tests/integrations_app/public/test_argparse.py, tests/integrations_app/public/test_boring_app.py, tests/integrations_app/public/test_commands_and_api.py, tests/integrations_app/public/test_drive.py, tests/integrations_app/public/test_gradio.py, tests/integrations_app/public/test_installation_commands_app.py, tests/integrations_app/public/test_layout.py, tests/integrations_app/public/test_multi_node.py, tests/integrations_app/public/test_payload.py, tests/integrations_app/public/test_pickle_or_not.py, tests/integrations_app/public/test_scripts.py, tests/integrations_app/public/test_template_react_ui.py, tests/integrations_app/public/test_template_streamlit_ui.py, tests/integrations_app/public/test_v0_app.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py, docs/source-app/examples/dag/dag_from_scratch.rst, docs/source-app/glossary/storage/drive_content.rst, docs/source-app/glossary/storage/drive_content_old.rst, docs/source-app/levels/basic/hello_components/run_ptl_script.py, docs/source-app/moving_to_the_cloud.rst.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to src/lightning/app/components/python/popen.py, src/lightning/app/components/python/tracer.py, src/lightning/app/components/serve/gradio_server.py, src/lightning/app/core/flow.py.

🟢 link-check

Check ID	Status
markdown-link-check	success	✅

These checks are required after the changes to examples/app/hpo/README.md, examples/app/multi_node/README.md, examples/app/v0/README.md.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

.github/checkgroup.yml

ethanwharris

LGTM 😃

Borda

btw, duplicated with #17073

awaelchli added 2 commits March 13, 2023 01:35

move

172cecc

init files

6502bc4

awaelchli added example refactor app (removed) Generic label for Lightning App package labels Mar 13, 2023

awaelchli added this to the 2.0 milestone Mar 13, 2023

reset change

5e671fb

awaelchli marked this pull request as ready for review March 13, 2023 00:41

awaelchli requested review from Borda, ethanwharris, hhsecond, lantiga, tchaton and williamFalcon as code owners March 13, 2023 00:41

awaelchli added 5 commits March 13, 2023 01:57

missed

cc549ed

more

e1f73c3

relative path

234dfb5

e2e tests

5422507

update checkgroup

50a235d

awaelchli requested review from akihironitta and carmocca as code owners March 13, 2023 01:29

github-actions bot added the ci Continuous Integration label Mar 13, 2023

reference

59b9e1d

akihironitta approved these changes Mar 13, 2023

View reviewed changes

carmocca approved these changes Mar 13, 2023

View reviewed changes

.github/checkgroup.yml Outdated Show resolved Hide resolved

.github/checkgroup.yml Show resolved Hide resolved

mergify bot added the ready PRs ready to be merged label Mar 13, 2023

update app_*

152677b

awaelchli added the fun Staff contributions outside working hours - to differentiate from the "community" label label Mar 13, 2023

awaelchli mentioned this pull request Mar 14, 2023

refactor App examples to examples/app/ #17073

Closed

7 tasks

edenlightning modified the milestones: 2.0, 2.0.x Mar 14, 2023

carmocca modified the milestones: 2.0.x, 2.1 Mar 14, 2023

carmocca enabled auto-merge (squash) March 14, 2023 16:48

ethanwharris approved these changes Mar 14, 2023

View reviewed changes

Borda approved these changes Mar 14, 2023

View reviewed changes

lexierule disabled auto-merge March 14, 2023 18:48

lexierule merged commit 550fa5f into master Mar 14, 2023

lexierule deleted the app/move-examples branch March 14, 2023 18:48

awaelchli modified the milestones: 2.1, 2.0 Mar 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Organize app examples #17045

Organize app examples #17045

Uh oh!

awaelchli commented Mar 13, 2023 •

edited by Borda

Loading

Uh oh!

github-actions bot commented Mar 13, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

ethanwharris left a comment

Uh oh!

Borda left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Organize app examples #17045

Organize app examples #17045

Uh oh!

Conversation

awaelchli commented Mar 13, 2023 • edited by Borda Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Uh oh!

github-actions bot commented Mar 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚡ Required checks status: All passing 🟢

Groups summary

Uh oh!

Uh oh!

Uh oh!

ethanwharris left a comment

Choose a reason for hiding this comment

Uh oh!

Borda left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

awaelchli commented Mar 13, 2023 •

edited by Borda

Loading

github-actions bot commented Mar 13, 2023 •

edited

Loading