Skip to content

Conversation

@aniketmaurya
Copy link
Contributor

@aniketmaurya aniketmaurya commented Mar 14, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 14, 2023
@aniketmaurya aniketmaurya marked this pull request as ready for review March 14, 2023 06:40
Copy link
Collaborator

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have pytorch group od dependencies, but maybe worse to check what would be listed there...

@awaelchli awaelchli changed the title rename PL installation to pip install lightning[pytorch] Rename PL installation to pip install lightning Mar 14, 2023
@awaelchli awaelchli added the docs Documentation related label Mar 14, 2023
@mergify mergify bot added the ready PRs ready to be merged label Mar 14, 2023
@Borda Borda enabled auto-merge (squash) March 14, 2023 11:16
Co-authored-by: edenlightning <66261195+edenlightning@users.noreply.github.com>
@carmocca carmocca added this to the 2.0 milestone Mar 14, 2023
@lexierule lexierule disabled auto-merge March 14, 2023 18:47
@lexierule lexierule merged commit 5d58736 into Lightning-AI:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants