ci: separate integrations #17170

Borda · 2023-03-22T14:55:58Z

What does this PR do?

Installing these integration introduces cyclic dependencies.

Before submitting

Was this discussed/agreed via a GitHub issue? (not for typos and docs)
Did you read the contributor guideline, Pull Request section?
Did you make sure your PR does only one thing, instead of bundling different changes together?
Did you make sure to update the documentation with your changes? (if necessary)
Did you write any new necessary tests? (not for typos and docs)
Did you verify new and existing tests pass locally with your changes?
Did you list all the breaking changes introduced by this pull request?
Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist

Is this pull request ready for review? (if not, please submit in draft mode)
Check that all items from Before submitting are resolved
Make sure the title is self-explanatory and the description concisely explains the PR
Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @akihironitta @Borda @tchaton

github-actions · 2023-03-22T14:56:41Z

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow

Check ID	Status
pl-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
pl-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
pl-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
pl-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
pl-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
pl-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
pl-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
pl-cpu (macOS-11, pytorch, 3.8, 1.13)	success	✅
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.13)	success	✅
pl-cpu (windows-2022, pytorch, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py, .github/workflows/ci-tests-pytorch.yml, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure GPU

Check ID	Status
pytorch-lightning (GPUs)	success	✅

These checks are required after the changes to .actions/assistant.py, .azure/gpu-tests-pytorch.yml, requirements/pytorch/strategies.txt, src/lightning/__setup__.py.

🟢 pytorch_lightning: Benchmarks

Check ID	Status
pytorch-lightning.Benchmark	success	✅

These checks are required after the changes to requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Azure HPU

Check ID	Status
pytorch-lightning (HPUs)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/__setup__.py, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Docs

Check ID	Status
make-doctest (pytorch)	success	✅
make-html (pytorch)	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/pytorch/strategies.txt.

🟢 pytorch_lightning: Docker

Check ID	Status
build-cuda (3.9, 1.11, 11.3.1)	success	✅
build-cuda (3.9, 1.12, 11.6.1)	success	✅
build-cuda (3.9, 1.13, 11.7.1)	success	✅
build-cuda (3.10, 2.0, 11.7.1)	success	✅
build-hpu (1.5.0, 1.11.0)	success	✅
build-ipu (3.9, 1.13)	success	✅
build-NGC	success	✅
build-pl (3.9, 1.11, 11.3.1)	success	✅
build-pl (3.9, 1.12, 11.6.1)	success	✅
build-pl (3.9, 1.13, 11.7.1)	success	✅
build-pl (3.10, 2.0, 11.7.1)	success	✅
build-xla (3.8, 1.12)	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/pytorch/strategies.txt.

🟢 lightning_fabric: CPU workflow

Check ID	Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11)	success	✅
fabric-cpu (macOS-11, lightning, 3.9, 1.12)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 1.13)	success	✅
fabric-cpu (macOS-11, lightning, 3.10, 2.0)	success	✅
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0)	success	✅
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11)	success	✅
fabric-cpu (windows-2022, lightning, 3.9, 1.12)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 1.13)	success	✅
fabric-cpu (windows-2022, lightning, 3.10, 2.0)	success	✅
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest)	success	✅
fabric-cpu (macOS-11, fabric, 3.8, 1.13)	success	✅
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13)	success	✅
fabric-cpu (windows-2022, fabric, 3.8, 1.13)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: Azure GPU

Check ID	Status
lightning-fabric (GPUs)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/__setup__.py.

🟢 lightning_app: Tests workflow

Check ID	Status
app-pytest (macOS-11, lightning, 3.8, latest)	success	✅
app-pytest (macOS-11, lightning, 3.8, oldest)	success	✅
app-pytest (macOS-11, app, 3.9, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, latest)	success	✅
app-pytest (ubuntu-20.04, lightning, 3.8, oldest)	success	✅
app-pytest (ubuntu-20.04, app, 3.9, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, latest)	success	✅
app-pytest (windows-2022, lightning, 3.8, oldest)	success	✅
app-pytest (windows-2022, app, 3.8, latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🔴 lightning_app: Examples

Check ID	Status
app-examples (macOS-11, lightning, 3.9, latest)	success	✅
app-examples (macOS-11, lightning, 3.9, oldest)	cancelled	🚫
app-examples (macOS-11, app, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, latest)	success	✅
app-examples (ubuntu-20.04, lightning, 3.9, oldest)	success	✅
app-examples (ubuntu-20.04, app, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, latest)	success	✅
app-examples (windows-2022, lightning, 3.9, oldest)	success	✅
app-examples (windows-2022, app, 3.9, latest)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 lightning: Store

Check ID	Status
Store.cloud (test_store Linux)	success	✅
Store.cloud (test_store Mac)	success	✅
Store.cloud (test_store Windows)	success	✅

These checks are required after the changes to src/lightning/__setup__.py.

🔴 lightning_app: Azure

Check ID	Status
App.cloud-e2e	failure	❌

These checks are required after the changes to .actions/assistant.py, src/lightning/__setup__.py.

🟢 lightning_app: Docs

Check ID	Status
make-doctest (app)	success	✅
make-html (app)	success	✅

These checks are required after the changes to .actions/assistant.py.

🟢 mypy

Check ID	Status
mypy	success	✅

These checks are required after the changes to .actions/assistant.py, requirements/_integrations/strategies.txt, requirements/pytorch/strategies.txt, src/lightning/__setup__.py.

🟢 install

Check ID	Status
install-pkg (ubuntu-22.04, app, 3.8)	success	✅
install-pkg (ubuntu-22.04, app, 3.10)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.8)	success	✅
install-pkg (ubuntu-22.04, fabric, 3.10)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.8)	success	✅
install-pkg (ubuntu-22.04, pytorch, 3.10)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.8)	success	✅
install-pkg (ubuntu-22.04, lightning, 3.10)	success	✅
install-pkg (ubuntu-22.04, notset, 3.8)	success	✅
install-pkg (ubuntu-22.04, notset, 3.10)	success	✅
install-pkg (macOS-12, app, 3.8)	success	✅
install-pkg (macOS-12, app, 3.10)	success	✅
install-pkg (macOS-12, fabric, 3.8)	success	✅
install-pkg (macOS-12, fabric, 3.10)	success	✅
install-pkg (macOS-12, pytorch, 3.8)	success	✅
install-pkg (macOS-12, pytorch, 3.10)	success	✅
install-pkg (macOS-12, lightning, 3.8)	success	✅
install-pkg (macOS-12, lightning, 3.10)	success	✅
install-pkg (macOS-12, notset, 3.8)	success	✅
install-pkg (macOS-12, notset, 3.10)	success	✅
install-pkg (windows-2022, app, 3.8)	success	✅
install-pkg (windows-2022, app, 3.10)	success	✅
install-pkg (windows-2022, fabric, 3.8)	success	✅
install-pkg (windows-2022, fabric, 3.10)	success	✅
install-pkg (windows-2022, pytorch, 3.8)	success	✅
install-pkg (windows-2022, pytorch, 3.10)	success	✅
install-pkg (windows-2022, lightning, 3.8)	success	✅
install-pkg (windows-2022, lightning, 3.10)	success	✅
install-pkg (windows-2022, notset, 3.8)	success	✅
install-pkg (windows-2022, notset, 3.10)	success	✅

These checks are required after the changes to .actions/assistant.py, src/lightning/__setup__.py, requirements/_integrations/strategies.txt, requirements/pytorch/strategies.txt.

Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

.github/workflows/ci-tests-pytorch.yml

src/lightning/__setup__.py

src/pytorch_lightning/__setup__.py

codecov · 2023-03-22T20:48:07Z

Codecov Report

Merging #17170 (670145e) into master (c271d4c) will increase coverage by 13%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #17170     +/-   ##
=========================================
+ Coverage      68%      82%    +13%     
=========================================
  Files         436      418     -18     
  Lines       31793    31600    -193     
=========================================
+ Hits        21756    25814   +4058     
+ Misses      10037     5786   -4251

tests/tests_fabric/parity/utils.py

Borda · 2023-03-23T09:15:36Z

@carmocca moreover, it addresses an issue with not being able to build docker because of these strategies...

requirements/_integrations/strategies.txt

requirements/pytorch/strategies.txt

* integrations * Rename * Apply suggestions from code review * cut out * skip _ * fix * setup * 1e-2 * uninstall * revert * note

integrations

4abe233

Borda added the ci Continuous Integration label Mar 22, 2023

Borda requested review from akihironitta, awaelchli, carmocca, lantiga and tchaton as code owners March 22, 2023 14:55

github-actions bot added the pl Generic label for PyTorch Lightning package label Mar 22, 2023

carmocca reviewed Mar 22, 2023

View reviewed changes

.github/workflows/ci-tests-pytorch.yml Outdated Show resolved Hide resolved

.github/workflows/ci-tests-pytorch.yml Show resolved Hide resolved

Rename

6963d8b

Borda commented Mar 22, 2023

View reviewed changes

src/lightning/__setup__.py Outdated Show resolved Hide resolved

src/pytorch_lightning/__setup__.py Outdated Show resolved Hide resolved

Borda and others added 4 commits March 22, 2023 16:57

Apply suggestions from code review

ec57092

cut out

e7ec8ef

skip _

a7feb5e

fix

b1991f2

Borda added 2 commits March 22, 2023 21:54

setup

b06d4d3

1e-2

283fd64

Borda requested a review from justusschock as a code owner March 22, 2023 21:03

github-actions bot added the fabric lightning.fabric.Fabric label Mar 22, 2023

uninstall

2b48a73

Borda commented Mar 23, 2023

View reviewed changes

tests/tests_fabric/parity/utils.py Outdated Show resolved Hide resolved

Borda changed the title ~~ci: separate integrations [wip]~~ ci: separate integrations Mar 23, 2023

revert

600c91f

Borda requested a review from carmocca March 23, 2023 09:22

github-actions bot removed the fabric lightning.fabric.Fabric label Mar 23, 2023

Borda commented Mar 23, 2023

View reviewed changes

requirements/_integrations/strategies.txt Show resolved Hide resolved

note

670145e

Borda enabled auto-merge (squash) March 23, 2023 09:25

Borda mentioned this pull request Mar 23, 2023

Replace HPU with external implementation #17067

Merged

10 tasks

Borda added the priority: 1 Medium priority task label Mar 23, 2023

akihironitta approved these changes Mar 23, 2023

View reviewed changes

Borda mentioned this pull request Mar 23, 2023

test: adjust is_timing_close #17178

Merged

7 tasks

tchaton approved these changes Mar 23, 2023

View reviewed changes

awaelchli reviewed Mar 23, 2023

View reviewed changes

requirements/pytorch/strategies.txt Show resolved Hide resolved

mergify bot added the ready PRs ready to be merged label Mar 23, 2023

awaelchli approved these changes Mar 23, 2023

View reviewed changes

lantiga approved these changes Mar 24, 2023

View reviewed changes

lantiga disabled auto-merge March 24, 2023 08:46

lantiga merged commit e04d4fd into master Mar 24, 2023

lantiga deleted the ci/integrations branch March 24, 2023 08:46

carmocca pushed a commit that referenced this pull request Mar 30, 2023

ci: separate integrations (#17170)

cc3ac27

* integrations * Rename * Apply suggestions from code review * cut out * skip _ * fix * setup * 1e-2 * uninstall * revert * note

lantiga pushed a commit that referenced this pull request Mar 30, 2023

ci: separate integrations (#17170)

31c5f27

* integrations * Rename * Apply suggestions from code review * cut out * skip _ * fix * setup * 1e-2 * uninstall * revert * note

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ci: separate integrations #17170

ci: separate integrations #17170

Uh oh!

Borda commented Mar 22, 2023 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 22, 2023 •

edited

Loading

Uh oh!

Uh oh!

Borda commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ci: separate integrations #17170

ci: separate integrations #17170

Uh oh!

Conversation

Borda commented Mar 22, 2023 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

PR review

Uh oh!

github-actions bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⛈️ Required checks status: Has failure 🔴

Groups summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Borda commented Mar 23, 2023

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Borda commented Mar 22, 2023 •

edited by github-actions bot

Loading

github-actions bot commented Mar 22, 2023 •

edited

Loading

codecov bot commented Mar 22, 2023 •

edited

Loading