Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Apr 14, 2023

What does this PR do?

testing with LTS

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @carmocca @Borda @awaelchli

@Borda Borda added the tests label Apr 14, 2023
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Apr 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2023

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🔴 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu (macOS-11, pytorch, 3.8, 1.11) success
pl-cpu (macOS-11, pytorch, 3.9, 1.12) success
pl-cpu (macOS-11, pytorch, 3.10, 1.13) success
pl-cpu (macOS-11, pytorch, 3.8, 1.10, oldest) success
pl-cpu (ubuntu-20.04, pytorch, 3.8, 1.10) success
pl-cpu (ubuntu-20.04, pytorch, 3.9, 1.11) failure
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.12) success
pl-cpu (ubuntu-20.04, pytorch, 3.10, 1.13) success
pl-cpu (ubuntu-20.04, pytorch, 3.7, 1.10, oldest) success
pl-cpu (windows-2022, pytorch, 3.9, 1.11) success
pl-cpu (windows-2022, pytorch, 3.10, 1.12) success
pl-cpu (windows-2022, pytorch, 3.10, 1.13) success
pl-cpu (windows-2022, pytorch, 3.7, 1.10, oldest) success
pl-cpu (slow, macOS-11, pytorch, 3.7, 1.11) success
pl-cpu (slow, ubuntu-20.04, pytorch, 3.7, 1.11) success
pl-cpu (slow, windows-2022, pytorch, 3.7, 1.11) success
pl-cpu (macOS-11, lightning, 3.8, 1.13) success
pl-cpu (ubuntu-20.04, lightning, 3.8, 1.13) success
pl-cpu (windows-2022, lightning, 3.8, 1.13) success

These checks are required after the changes to tests/tests_pytorch/helpers/simple_models.py, tests/legacy/back-compatible-versions.txt, tests/legacy/generate_checkpoints.sh, tests/legacy/simple_classif_training.py.

🔴 pytorch_lightning: Azure GPU
Check ID Status
pytorch-lightning (GPUs) failure

These checks are required after the changes to tests/tests_pytorch/helpers/simple_models.py.

🟢 pytorch_lightning: Azure HPU
Check ID Status
pytorch-lightning (HPUs) success

These checks are required after the changes to tests/tests_pytorch/helpers/simple_models.py.

🟢 pytorch_lightning: Docs
Check ID Status
make-doctest (pytorch) success
make-html (pytorch) success

These checks are required after the changes to docs/source-pytorch/past_versions.rst.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 90 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda added this to the v1.9.x milestone Apr 14, 2023
@Borda Borda enabled auto-merge (squash) April 14, 2023 08:46
@Borda Borda changed the title lts: Adding tests for legacy checkpoints lts: Adding tests for legacy checkpoints 1.8.x Apr 28, 2023
@github-actions github-actions bot added the ci Continuous Integration label Apr 28, 2023
@Borda Borda force-pushed the lts/checkpoints branch from 3200996 to 3fef1e1 Compare May 1, 2023 19:44
@Borda Borda added the checkpointing Related to checkpointing label May 4, 2023
@mergify mergify bot added the ready PRs ready to be merged label May 4, 2023
@Borda
Copy link
Collaborator Author

Borda commented May 4, 2023

Strategy tests are failing because of Horovod
TPU shall be disabled as done in #17560
IPU tests are not touching this case...

@lantiga lantiga disabled auto-merge May 4, 2023 10:33
@lantiga lantiga merged commit 468eed1 into release/LTS May 4, 2023
@lantiga lantiga deleted the lts/checkpoints branch May 4, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

checkpointing Related to checkpointing ci Continuous Integration pl Generic label for PyTorch Lightning package ready PRs ready to be merged tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants