Skip to content

Conversation

@edenlightning
Copy link
Contributor

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label May 11, 2023
@edenlightning edenlightning changed the title fix links in fabric [WIP] fix links in fabric May 11, 2023
@edenlightning edenlightning marked this pull request as ready for review May 11, 2023 17:46
@Borda Borda changed the title [WIP] fix links in fabric fix links in fabric May 11, 2023
@mergify mergify bot added the ready PRs ready to be merged label May 11, 2023
@Borda Borda merged commit e470997 into Lightning-AI:master May 11, 2023
@awaelchli awaelchli added this to the 2.0.x milestone May 11, 2023
Borda pushed a commit that referenced this pull request Jun 2, 2023
(cherry picked from commit e470997)
Borda pushed a commit that referenced this pull request Jun 2, 2023
(cherry picked from commit e470997)
lantiga pushed a commit that referenced this pull request Jun 2, 2023
(cherry picked from commit e470997)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants