Skip to content

Conversation

@baskrahmer
Copy link
Contributor

What does this PR do?

Update documentation - omitted mention of QuantizationAwareTraining callback, which was recently removed from Lightning.

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label May 16, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@awaelchli awaelchli added the docs Documentation related label May 17, 2023
@awaelchli awaelchli added this to the 2.1 milestone May 17, 2023
@awaelchli awaelchli added the community This PR is from the community label May 17, 2023
@Borda Borda enabled auto-merge (squash) May 17, 2023 17:23
@Borda Borda merged commit a37f5a5 into Lightning-AI:master May 17, 2023
@mergify mergify bot added the ready PRs ready to be merged label May 17, 2023
Borda pushed a commit that referenced this pull request Jun 2, 2023
Co-authored-by: bas <bas.krahmer@talentflyxpert.com>
(cherry picked from commit a37f5a5)
Borda pushed a commit that referenced this pull request Jun 2, 2023
Co-authored-by: bas <bas.krahmer@talentflyxpert.com>
(cherry picked from commit a37f5a5)
lantiga pushed a commit that referenced this pull request Jun 2, 2023
Co-authored-by: bas <bas.krahmer@talentflyxpert.com>
(cherry picked from commit a37f5a5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from the community docs Documentation related pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants