Skip to content

Fix TensorBoardLogger.log_graph not recording the graph #17926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 17, 2023
Merged

Fix TensorBoardLogger.log_graph not recording the graph #17926

merged 8 commits into from
Jul 17, 2023

Conversation

@shihaoyin
Copy link
Contributor

@shihaoyin shihaoyin commented Jun 26, 2023

What does this PR do?

Fixes #17844

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Jun 26, 2023
awaelchli
awaelchli reviewed Jun 27, 2023
View reviewed changes
@awaelchli awaelchli changed the title fixes no graph recorded bug Fix TensorBoardLogger.log_graph not recording the graph Jun 27, 2023
@awaelchli awaelchli added bug Something isn't working logger: tensorboard community This PR is from the community labels Jun 27, 2023
@awaelchli awaelchli self-assigned this Jun 27, 2023
@awaelchli awaelchli added this to the 2.0.x milestone Jun 27, 2023
@awaelchli awaelchli merged commit c31ef77 into Lightning-AI:master Jul 17, 2023
@mergify mergify bot added the ready PRs ready to be merged label Jul 17, 2023
Borda added a commit that referenced this pull request Jul 19, 2023
@shihaoyin @Borda
@awaelchli @pre-commit-ci
Fix TensorBoardLogger.log_graph not recording the graph (#17926)
b4ebc01 
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c31ef77)
lantiga pushed a commit that referenced this pull request Jul 21, 2023
@shihaoyin @Borda
@awaelchli @pre-commit-ci @lantiga
Fix TensorBoardLogger.log_graph not recording the graph (#17926)
3dad856 
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c31ef77)
Borda added a commit that referenced this pull request Sep 12, 2023
@shihaoyin @Borda
@awaelchli @pre-commit-ci
Fix TensorBoardLogger.log_graph not recording the graph (#17926)
8095d9f 
Co-authored-by: Jirka Borovec <6035284+Borda@users.noreply.github.com>
Co-authored-by: awaelchli <aedu.waelchli@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit c31ef77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

2 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@awaelchli awaelchli

Labels

bug Something isn't working community This PR is from the community fabric lightning.fabric.Fabric logger: tensorboard ready PRs ready to be merged

Projects

None yet

Milestone

2.0.x

Development

Successfully merging this pull request may close these issues.

fabric.logger.log_graph() seems to do nothing

4 participants

@shihaoyin @awaelchli @carmocca @Borda