Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 10, 2023

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @justusschock @awaelchli @carmocca @Borda

@Borda Borda added the tests label Aug 10, 2023
@Borda Borda added this to the 2.0.x milestone Aug 10, 2023
@github-actions github-actions bot added the fabric lightning.fabric.Fabric label Aug 10, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

⚡ Required checks status: All passing 🟢

Groups summary

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu (macOS-11, lightning, 3.8, 1.11) success
fabric-cpu (macOS-11, lightning, 3.9, 1.12) success
fabric-cpu (macOS-11, lightning, 3.10, 1.13) success
fabric-cpu (macOS-11, lightning, 3.10, 2.0) success
fabric-cpu (macOS-11, lightning, 3.8, 1.11, oldest) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11) success
fabric-cpu (ubuntu-20.04, lightning, 3.9, 1.12) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 1.13) success
fabric-cpu (ubuntu-20.04, lightning, 3.10, 2.0) success
fabric-cpu (ubuntu-20.04, lightning, 3.8, 1.11, oldest) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11) success
fabric-cpu (windows-2022, lightning, 3.9, 1.12) success
fabric-cpu (windows-2022, lightning, 3.10, 1.13) success
fabric-cpu (windows-2022, lightning, 3.10, 2.0) success
fabric-cpu (windows-2022, lightning, 3.8, 1.11, oldest) success
fabric-cpu (macOS-11, fabric, 3.8, 1.13) success
fabric-cpu (ubuntu-20.04, fabric, 3.8, 1.13) success
fabric-cpu (windows-2022, fabric, 3.8, 1.13) success

These checks are required after the changes to tests/tests_fabric/utilities/test_warnings.py.

🟢 lightning_fabric: Azure GPU
Check ID Status
[lightning-fabric (GPUs) (testing Fabric latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=169356&view=logs&jobId=3f274fac-2e11-54ca-487e-194c91f3ae9f) success
[lightning-fabric (GPUs) (testing Lightning latest)](https://dev.azure.com/Lightning-AI/72ab7ed8-b00f-4b6e-b131-3388f7ffafa7/_build/results?buildId=169356&view=logs&jobId=2a86d09f-f187-5efb-70b9-b75304f1c617) success

These checks are required after the changes to tests/tests_fabric/utilities/test_warnings.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda added the refactor label Aug 10, 2023
@mergify mergify bot added the ready PRs ready to be merged label Aug 10, 2023
Borda and others added 2 commits August 10, 2023 10:22
@awaelchli awaelchli merged commit 3ac550f into master Aug 12, 2023
@awaelchli awaelchli deleted the tests/warmings branch August 12, 2023 11:59
Borda added a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit 3ac550f)
lexierule pushed a commit that referenced this pull request Aug 14, 2023
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
(cherry picked from commit 3ac550f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fabric lightning.fabric.Fabric ready PRs ready to be merged refactor tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants