Skip to content

Conversation

@Tribhuvan0
Copy link
Contributor

@Tribhuvan0 Tribhuvan0 commented Sep 7, 2023

What does this PR do?

On the glossary page, it changes the orientation of mount entry so that it can align with all other cards

Go to the Glossary page: https://lightning.ai/docs/app/stable/glossary/

Scroll down to the Mounts entry on the page. The formatting is incorrect.

I changed the code to align the mount entry
This is how it looked earier: Screenshot 2023-09-07 at 11 50 32 PM

Fixes #17698

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18502.org.readthedocs.build/en/18502/

@github-actions github-actions bot added the app (removed) Generic label for Lightning App package label Sep 7, 2023
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@awaelchli awaelchli added docs Documentation related community This PR is from the community labels Sep 7, 2023
@awaelchli awaelchli added this to the 2.1 milestone Sep 7, 2023
@Borda Borda merged commit 12af771 into Lightning-AI:master Sep 12, 2023
@mergify mergify bot added the ready PRs ready to be merged label Sep 12, 2023
@Tribhuvan0 Tribhuvan0 deleted the Tribhuvan0-patch-1 branch September 12, 2023 08:03
Borda pushed a commit that referenced this pull request Sep 12, 2023
(cherry picked from commit 12af771)
lantiga pushed a commit that referenced this pull request Sep 14, 2023
(cherry picked from commit 12af771)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app (removed) Generic label for Lightning App package community This PR is from the community docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mounts item on Glossary page not formatted correctly

3 participants