-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Introduce Cache 1/n #18642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Introduce Cache 1/n #18642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…htning into introduce_cache
for more information, see https://pre-commit.ci
…htning into introduce_cache
for more information, see https://pre-commit.ci
…htning into introduce_cache
for more information, see https://pre-commit.ci
…htning into introduce_cache
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #18642 +/- ##
=========================================
- Coverage 83% 64% -20%
=========================================
Files 428 435 +7
Lines 33484 34530 +1046
=========================================
- Hits 27904 21974 -5930
- Misses 5580 12556 +6976 |
ethanwharris
approved these changes
Oct 6, 2023
justusschock
approved these changes
Oct 9, 2023
Member
justusschock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just some minor comments
Borda
reviewed
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
Continuous Integration
dependencies
Pull requests that update a dependency file
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the Cache and CacheDataLoader object to optimise data fetching in the cloud.
Here are the different ways of using the Cache.
For beginners:
For advanced users:
In the follow-ups PRs, I will investigate the followings:
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--18642.org.readthedocs.build/en/18642/
cc @Borda