Skip to content

Conversation

@matsumotosan
Copy link
Contributor

@matsumotosan matsumotosan commented Oct 4, 2023

What does this PR do?

Must be fixed for Lightning-AI/torchmetrics#2141 to pass

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18714.org.readthedocs.build/en/18714/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Oct 4, 2023
@matsumotosan matsumotosan changed the title use new update called use new update_called from metrics Oct 4, 2023
@awaelchli awaelchli added logging Related to the `LoggerConnector` and `log()` community This PR is from the community labels Oct 4, 2023
Copy link
Contributor

@ishandutta0098 ishandutta0098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the steps for using the torchmetrics version to determine whether to use the public property or the private property

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #18714 (f326ff1) into master (77eef8a) will decrease coverage by 7%.
Report is 1 commits behind head on master.
The diff coverage is 100%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #18714     +/-   ##
=========================================
- Coverage      58%      50%     -7%     
=========================================
  Files         428      420      -8     
  Lines       33481    33338    -143     
=========================================
- Hits        19303    16817   -2486     
- Misses      14178    16521   +2343     

@mergify mergify bot added the ready PRs ready to be merged label Oct 6, 2023
@awaelchli awaelchli merged commit fdae213 into Lightning-AI:master Oct 6, 2023
@matsumotosan matsumotosan deleted the metrics/update-called branch October 7, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community This PR is from the community logging Related to the `LoggerConnector` and `log()` pl Generic label for PyTorch Lightning package ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants