Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Oct 6, 2023

What does this PR do?

building fabric and pytorch docs as previewed in RTFD
continued of #17086

image

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--18738.org.readthedocs.build/en/18738/

cc @Borda

@Borda Borda added this to the 2.1 milestone Oct 6, 2023
@github-actions github-actions bot added the docs Documentation related label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda force-pushed the rtfd/building-docs branch from cf98cb3 to 50b49e4 Compare October 6, 2023 18:45
@Borda Borda force-pushed the rtfd/building-docs branch from 50b49e4 to 6ffbb37 Compare October 6, 2023 18:47
Copy link
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice!

Copy link
Contributor

@carmocca carmocca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@carmocca carmocca merged commit 0777aab into master Oct 7, 2023
@carmocca carmocca deleted the rtfd/building-docs branch October 7, 2023 09:57
@mergify mergify bot added the ready PRs ready to be merged label Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation related ready PRs ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants