-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Internal Refactor: Reroute Implementations #21354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
⚡ Required checks status: All passing 🟢Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🟢 pytorch_lightning: lit GPU
These checks are required after the changes to 🟢 Benchmarks
These checks are required after the changes to 🟢 fabric: Docs
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🟢 lightning_fabric: lit GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #21354 +/- ##
=========================================
+ Coverage 87% 89% +3%
=========================================
Files 269 269
Lines 23799 22058 -1741
=========================================
- Hits 20618 19732 -886
+ Misses 3181 2326 -855 |
|
failures are probably due to |
39c75ae to
61b6960
Compare
61b6960 to
b9296d2
Compare
This reverts commit 9a10959.
* forward xla impl * forward logger implementation * forward logger implementation: mlflow * update neptune logger * forward kubeflow implementation * forward lsf env * move torchelastic * update xla env * forward bitsandbytes * forward deepspeed precision * forward transformer engine * forward XLA precision * forward deepspeed strategy fabric * integrate xla strategies * update pytorch deepspeed precision * forward trainer xla single device * XLA ddp trainer * update * update * update * update * update * update * update * update * update * update * update * update * update * update * update fabric tests * fabric tests * tests * update version * update * update * update * update * update * update * fix doc issue * fix mypy issue * fix readthedocs and ci cpu tests * update * update * update * update * update * update * fix deepspeed assertion * update * fix transformer engine mock * update * logger mocks * add tpu mocks * update * update * update * update * fix docmake * update * update * fix loggers error * update * update * update * update * pin cuda version * update * try with removing libnccl downloading * undo cuda pinning * update * update * corretly handle model property * update error types and add property forwarding * update * update * update * meow meow * claymore!!! * remove todo * remove todos + version * retrigger-ci to fix ple release issue * fix mocks xla --------- Co-authored-by: Deependu Jha <deependujha21@gmail.com> Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
Revert "Internal Refactor: Reroute Implementations (Lightning-AI#21354)" This reverts commit 9a10959.
What does this PR do?
Fixes #<issue_number>
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21354.org.readthedocs.build/en/21354/