Skip to content

Conversation

@justusschock
Copy link
Member

@justusschock justusschock commented Nov 11, 2025

What does this PR do?

Fixes #<issue_number>

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21354.org.readthedocs.build/en/21354/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Nov 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025

⚡ Required checks status: All passing 🟢

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, requirements/pytorch/base.txt, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/test_tpu.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_comet.py, tests/tests_pytorch/loggers/test_mlflow.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_tpu.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_xla.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/migration/test_utils.py.

🟢 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, pytorch, 3.10) success
pytorch.yml / Lit Job (lightning, 3.12) success
pytorch.yml / Lit Job (pytorch, 3.12) success

These checks are required after the changes to requirements/pytorch/base.txt, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, tests/tests_pytorch/accelerators/test_xla.py, tests/tests_pytorch/callbacks/progress/test_tqdm_progress_bar.py, tests/tests_pytorch/conftest.py, tests/tests_pytorch/deprecated_api/test_no_removal_version.py, tests/tests_pytorch/graveyard/test_tpu.py, tests/tests_pytorch/loggers/conftest.py, tests/tests_pytorch/loggers/test_all.py, tests/tests_pytorch/loggers/test_comet.py, tests/tests_pytorch/loggers/test_mlflow.py, tests/tests_pytorch/loggers/test_neptune.py, tests/tests_pytorch/loggers/test_wandb.py, tests/tests_pytorch/models/test_tpu.py, tests/tests_pytorch/plugins/precision/test_deepspeed_precision.py, tests/tests_pytorch/plugins/precision/test_transformer_engine.py, tests/tests_pytorch/strategies/test_deepspeed.py, tests/tests_pytorch/strategies/test_xla.py, tests/tests_pytorch/trainer/connectors/test_accelerator_connector.py, tests/tests_pytorch/utilities/migration/test_utils.py, requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py.

🟢 Benchmarks
Check ID Status
benchmark.yml / Lit Job (fabric) success
benchmark.yml / Lit Job (pytorch) success

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 fabric: Docs
Check ID Status
docs-make (fabric, doctest) success
docs-make (fabric, html) success

These checks are required after the changes to src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, .github/workflows/docs-build.yml, requirements/fabric/base.txt.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, docs/source-pytorch/conf.py, .github/workflows/docs-build.yml, requirements/pytorch/base.txt.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/graveyard/test_tpu.py, tests/tests_fabric/plugins/environments/test_kubeflow.py, tests/tests_fabric/plugins/environments/test_slurm.py, tests/tests_fabric/plugins/environments/test_torchelastic.py, tests/tests_fabric/plugins/environments/test_xla.py, tests/tests_fabric/plugins/precision/test_transformer_engine.py, tests/tests_fabric/strategies/test_deepspeed.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-devel-ubuntu22.04, fabric, 3.10) success
fabric.yml / Lit Job (fabric, 3.12) success
fabric.yml / Lit Job (lightning, 3.12) success

These checks are required after the changes to requirements/fabric/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, tests/tests_fabric/conftest.py, tests/tests_fabric/graveyard/test_tpu.py, tests/tests_fabric/plugins/environments/test_kubeflow.py, tests/tests_fabric/plugins/environments/test_slurm.py, tests/tests_fabric/plugins/environments/test_torchelastic.py, tests/tests_fabric/plugins/environments/test_xla.py, tests/tests_fabric/plugins/precision/test_transformer_engine.py, tests/tests_fabric/strategies/test_deepspeed.py, tests/tests_fabric/strategies/test_deepspeed_integration.py, tests/tests_fabric/strategies/test_xla.py, tests/tests_fabric/strategies/test_xla_fsdp.py, tests/tests_fabric/test_connector.py, tests/tests_fabric/utilities/test_throughput.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to requirements/fabric/base.txt, requirements/pytorch/base.txt, src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to src/lightning/fabric/accelerators/xla.py, src/lightning/fabric/plugins/environments/kubeflow.py, src/lightning/fabric/plugins/environments/lsf.py, src/lightning/fabric/plugins/environments/slurm.py, src/lightning/fabric/plugins/environments/torchelastic.py, src/lightning/fabric/plugins/environments/xla.py, src/lightning/fabric/plugins/io/xla.py, src/lightning/fabric/plugins/precision/bitsandbytes.py, src/lightning/fabric/plugins/precision/deepspeed.py, src/lightning/fabric/plugins/precision/transformer_engine.py, src/lightning/fabric/plugins/precision/xla.py, src/lightning/fabric/strategies/deepspeed.py, src/lightning/fabric/strategies/launchers/xla.py, src/lightning/fabric/strategies/single_xla.py, src/lightning/fabric/strategies/xla.py, src/lightning/fabric/strategies/xla_fsdp.py, src/lightning/fabric/utilities/imports.py, src/lightning/fabric/utilities/testing/_runif.py, src/lightning/pytorch/accelerators/xla.py, src/lightning/pytorch/loggers/comet.py, src/lightning/pytorch/loggers/mlflow.py, src/lightning/pytorch/loggers/neptune.py, src/lightning/pytorch/loggers/wandb.py, src/lightning/pytorch/plugins/precision/deepspeed.py, src/lightning/pytorch/plugins/precision/xla.py, src/lightning/pytorch/strategies/deepspeed.py, src/lightning/pytorch/strategies/launchers/xla.py, src/lightning/pytorch/strategies/single_xla.py, src/lightning/pytorch/strategies/xla.py, src/lightning/pytorch/utilities/deepspeed.py, requirements/fabric/base.txt, requirements/pytorch/base.txt.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 75.43860% with 126 lines in your changes missing coverage. Please review.
✅ Project coverage is 89%. Comparing base (8ac4843) to head (b9296d2).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #21354     +/-   ##
=========================================
+ Coverage      87%      89%     +3%     
=========================================
  Files         269      269             
  Lines       23799    22058   -1741     
=========================================
- Hits        20618    19732    -886     
+ Misses       3181     2326    -855     

@deependujha
Copy link
Collaborator

failures are probably due to ple==2.6.0 was released immediately, rerunning them fixes it. We should probably do an empty commit, to trigger all job to run again.

@justusschock justusschock changed the title [WIP] Internal Refactor: Reroute Implementations Nov 19, 2025
@justusschock justusschock force-pushed the integrate_package branch 5 times, most recently from 39c75ae to 61b6960 Compare November 20, 2025 11:05
@lantiga lantiga merged commit 9a10959 into master Nov 21, 2025
119 checks passed
@lantiga lantiga deleted the integrate_package branch November 21, 2025 11:54
justusschock added a commit that referenced this pull request Nov 27, 2025
lantiga pushed a commit that referenced this pull request Nov 27, 2025
Revert "Internal Refactor: Reroute Implementations (#21354)"

This reverts commit 9a10959.
Iruos8805 pushed a commit to Iruos8805/pytorch-lightning that referenced this pull request Dec 4, 2025
* forward xla impl

* forward logger implementation

* forward logger implementation: mlflow

* update neptune logger

* forward kubeflow implementation

* forward lsf env

* move torchelastic

* update xla env

* forward bitsandbytes

* forward deepspeed precision

* forward transformer engine

* forward XLA precision

* forward deepspeed strategy fabric

* integrate xla strategies

* update pytorch deepspeed precision

* forward trainer xla single device

* XLA ddp trainer

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update

* update fabric tests

* fabric tests

* tests

* update version

* update

* update

* update

* update

* update

* update

* fix doc issue

* fix mypy issue

* fix readthedocs and ci cpu tests

* update

* update

* update

* update

* update

* update

* fix deepspeed assertion

* update

* fix transformer engine mock

* update

* logger mocks

* add tpu mocks

* update

* update

* update

* update

* fix docmake

* update

* update

* fix loggers error

* update

* update

* update

* update

* pin cuda version

* update

* try with removing libnccl downloading

* undo cuda pinning

* update

* update

* corretly handle model property

* update error types and add property forwarding

* update

* update

* update

* meow meow

* claymore!!!

* remove todo

* remove todos + version

* retrigger-ci to fix ple release issue

* fix mocks xla

---------

Co-authored-by: Deependu Jha <deependujha21@gmail.com>
Co-authored-by: Bhimraj Yadav <bhimrajyadav977@gmail.com>
Iruos8805 pushed a commit to Iruos8805/pytorch-lightning that referenced this pull request Dec 4, 2025
Revert "Internal Refactor: Reroute Implementations (Lightning-AI#21354)"

This reverts commit 9a10959.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file docs Documentation related fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants